Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add botbuilder-dialogs-declarative, botbuilder-dialogs-adaptive to de… #2020

Merged
merged 4 commits into from
Apr 14, 2020

Conversation

BruceHaley
Copy link
Contributor

…pendencies args list

This plus an updated "Replace version number" in the automated build fixes earlier errors in "npm run postinstall" and gets to a later error in "npm run build" in botbuilder-testing.

This in BotBuilder-JS-master-CI and BotBuilder-JS-master-daily.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…pendencies args list
@coveralls
Copy link

Pull Request Test Coverage Report for Build 119736

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 67.127%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 119459: -0.08%
Covered Lines: 10263
Relevant Lines: 14465

💛 - Coveralls

@BruceHaley BruceHaley merged commit 4f6e925 into master Apr 14, 2020
@BruceHaley BruceHaley deleted the v-bruhal/fixdependenciesargs4-13 branch April 14, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants