Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added assertNoReply to TestFlow/TestAdapter #2002

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

mdrichardson
Copy link
Contributor

Fixes #1504

Description

Adds assertNoReply() as a method for TestFlows. This is a port from C#.

Testing

Also adds three additional tests to ensure:

  • resolves if timeout hit while waiting for reply (this is done in C#, too)
  • throws if an unexpected reply is received
  • does not throw if no additional replies are received

@coveralls
Copy link

coveralls commented Apr 8, 2020

Pull Request Test Coverage Report for Build 122071

  • 11 of 14 (78.57%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 67.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-core/src/testAdapter.ts 11 14 78.57%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 122058: -0.07%
Covered Lines: 10345
Relevant Lines: 14551

💛 - Coveralls

@cleemullins
Copy link
Contributor

@Stevenic, @stevengum, can you please review?

Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit ee0960d into master Apr 21, 2020
@Stevenic Stevenic deleted the mdrichardson/assertNoReply branch April 21, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] add TestFlow.AssertNoReply and tests
4 participants