Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @types node dev dependency from botframework-streaming #1795

Merged
merged 34 commits into from
Mar 4, 2020
Merged
Changes from 2 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
4cf3fe3
replaced new Server with createNodeServer(); created test INodeSocket…
Zerryth Feb 26, 2020
7231d2b
removed new Func unit test
Zerryth Feb 26, 2020
0fd229b
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Zerryth Feb 26, 2020
ecd41bc
consolidated server-creation into 1 utils module; added unit tests
Zerryth Feb 26, 2020
f116243
Merge branch 'Zerryth/removeTypesNodeDevDependency' of https://github…
Zerryth Feb 26, 2020
e717537
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Zerryth Feb 26, 2020
a4b8f24
removed await from Promise.all, as it was originally
Zerryth Feb 26, 2020
271262c
Merge branch 'Zerryth/removeTypesNodeDevDependency' of https://github…
Zerryth Feb 26, 2020
805b3b5
Update libraries/botframework-streaming/tests/NamedPipe.test.js
Zerryth Feb 26, 2020
dc89d8c
replaced references to @types/node classes with bf-streaming interfac…
Zerryth Feb 27, 2020
ef932ea
Merge branch 'Zerryth/removeTypesNodeDevDependency' of https://github…
Zerryth Feb 27, 2020
f8be823
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Zerryth Feb 27, 2020
45b7292
added more signatures to INodeSocket to remove Socket type dependency…
Zerryth Feb 27, 2020
3bd6815
Merge branch 'Zerryth/removeTypesNodeDevDependency' of https://github…
Zerryth Feb 27, 2020
43847f5
cleaned up comment
Zerryth Feb 27, 2020
eba33a5
changed INodeSocket.connect() to return any, as the nested types on s…
Zerryth Feb 27, 2020
91a5bca
changed Buffer to INodeBuffer type hint
Zerryth Feb 27, 2020
31e1074
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Zerryth Feb 27, 2020
820e8ae
added type guards to ensure we're getting an INodeServer back from cr…
Zerryth Feb 27, 2020
66132ef
Merge branch 'Zerryth/removeTypesNodeDevDependency' of https://github…
Zerryth Feb 27, 2020
a40e263
added unit test
Zerryth Feb 27, 2020
9d25bd8
added duck typing checks for server methods
Zerryth Feb 27, 2020
1e852bb
Added methods to INodeSocket to remove dependency on node stream.Dupl…
Zerryth Feb 27, 2020
48e2ad4
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Zerryth Feb 27, 2020
9c0f058
put server-creation in trycatch block, as we don't know if node 'net'…
Zerryth Feb 28, 2020
0141a89
Merge branch 'Zerryth/removeTypesNodeDevDependency' of https://github…
Zerryth Feb 28, 2020
2ce87d8
removed space from top of imports in tests
Zerryth Feb 28, 2020
40c021c
added false path to checks (whoops, forgot them)
Zerryth Feb 28, 2020
66fdb43
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Zerryth Feb 28, 2020
db5ebc9
moved imort below comment
Zerryth Feb 28, 2020
1c854b0
Merge branch 'Zerryth/removeTypesNodeDevDependency' of https://github…
Zerryth Feb 28, 2020
c271100
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Zerryth Feb 28, 2020
41fad65
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Zerryth Mar 3, 2020
dd57eee
Merge branch 'master' into Zerryth/removeTypesNodeDevDependency
Stevenic Mar 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

These merge commits were added into this branch cleanly.

There are no new changes to show.