-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudAdapter don't work with Teams SSO #4408
Labels
Bot Services
Required for internal Azure reporting. Do not delete. Do not change color.
bug
Indicates an unexpected problem or an unintended behavior.
customer-reported
Issue is created by anyone that is not a collaborator in the repository.
Comments
interested in the answer to this issue as well |
Hi @johnataylor. We were able to reproduce this issue using the bot-conversation-sso-quickstart sample. |
Thanks @erquirogasw. Can I assign this issue to you? |
@ramfattah sure. We already have the fix and we are finishing adding new unit tests. |
This was referenced Feb 6, 2023
johnataylor
pushed a commit
that referenced
this issue
Feb 8, 2023
* Updated teamsSSOTokenExchangeMiddleware.ts * Updated wrong provided token message * Code improvements * Suggested changes applied * Added unit tests. --------- Co-authored-by: Emiliano Quiroga <[email protected]>
tracyboehrer
pushed a commit
that referenced
this issue
Feb 28, 2023
* Updated teamsSSOTokenExchangeMiddleware.ts * Updated wrong provided token message * Code improvements * Suggested changes applied * Added unit tests. --------- Co-authored-by: Emiliano Quiroga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bot Services
Required for internal Azure reporting. Do not delete. Do not change color.
bug
Indicates an unexpected problem or an unintended behavior.
customer-reported
Issue is created by anyone that is not a collaborator in the repository.
Versions
What package version of the SDK are you using. 4.19.0
What nodejs version are you using: 16.19.0
What browser version are you using: Teams Windows Client
What os are you using. Windows 10
Describe the bug
Teams SSO doesn't work with the CloudAdapter class. I spent a lot of time with debugging and checking my configuration.
I followed the instructions at this repo: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-conversation-sso-quickstart/js
After sending the OAuthPromt Dialog, I get an error message "ExtendedUserTokenProvider".
If I use the deprecated BotFrameworkAdapter everything works as expected.
This happens because the CloudAdapter doesn't implement the "exchangeToken" method (i guess).
So I'm not sure whether the samples or the lib is not as expected.
To Reproduce
Use the code and instructions from: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-conversation-sso-quickstart/js
Expected behavior
Teams SSO with the CloudAdapter class.
The text was updated successfully, but these errors were encountered: