Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language (#6554) #4369

Closed
github-actions bot opened this issue Nov 18, 2022 · 0 comments · Fixed by #4388
Closed

port: [#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language (#6554) #4369

github-actions bot opened this issue Nov 18, 2022 · 0 comments · Fixed by #4388
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in [#6531] Prompt validation of confirm prompt in chatbot is not working for newly added language (#6554) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6531

Description

This PR adds the new RecognizeLanguage property in the PromptOptions class to be used in the onRecognizedAsync method allowing a different language than the one determined by the activity.
It also updates the onRecognizedAsync method of the ConfirmPrompt class to use this property solving the issue when a ConfirmPrompt is used along with a TranslationMiddleware.

Specific Changes

  • Updated PromptOptions class adding the RecognizeLanguage property.
  • Updated the onRecognizedAsync method of the ConfirmPrompt class using the new property.
  • Added a unit test in ConfirmPromptTests to cover the new test case.

Testing

These images show a bot using the translator service and the confirm prompt working as expected.
image

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Nov 18, 2022
@ceciliaavila ceciliaavila mentioned this issue Dec 13, 2022
Merged
tracyboehrer pushed a commit that referenced this issue Jan 4, 2023
@ceciliaavila
port: [#4369] Prompt validation of confirm prompt in chatbot is not w…
fe88652 
…orking for newly added language (#6554) (#4388)

* Add recognizeLanguage property in PromptOptions interface

* api file updated

Co-authored-by: Emiliano Quiroga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
1 participant
@JuanAr