Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#5766] Choice options separator should be multi language (#6366) #4270

Closed
github-actions bot opened this issue Jun 27, 2022 · 0 comments · Fixed by #4293
Closed

port: [#5766] Choice options separator should be multi language (#6366) #4270

github-actions bot opened this issue Jun 27, 2022 · 0 comments · Fixed by #4293
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in [#5766] Choice options separator should be multi language (#6366) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5766

Description

This PR updates the ChoiceOptions to support LG allowing to define different template expressions for each language.
It also adds unit tests to cover the new code.

Specific Changes

  • Updated ChoiceInput to get the choice options from an expression.
  • Updated ConfirmInput to get the choice options from an expression.
  • Added the new class ChoiceOptionsSet containing the BindAsync method to map the LG expression into a ChoiceFactoryOptions object.
  • Updated ChoiceInput and ConfirmInput schemas.
  • Added new tests in ActionTests class:
    • Action_ChoicesWithChoiceOptions.test.dialog
    • Action_ChoicesWithChoiceOptionsTemplate.test.dialog
    • Action_ConfirmInputWithChoiceOptions.test.dialog
    • Action_ConfirmInputWithChoiceOptionsTemplate.test.dialog
  • Added new test class ChoiceOptionsSetTests.

Testing

These images show the new unit tests passing and a multilingual bot using expressions to translate the choice options separators.
image
image

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jun 27, 2022
@sw-joelmut sw-joelmut mentioned this issue Jul 22, 2022
Merged
tracyboehrer pushed a commit that referenced this issue Jul 25, 2022
@sw-joelmut
port: [#4270] Choice options separator should be multi language (#636…
2bb7475 
…6) (#4293)

* Add ChoiceOptionsSet

* Add unit tests for ChoiceOptionsSet

* Update schema files

* Fix test:compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4270] Choice options separator should be multi language (#6366) microsoft/botbuilder-js
1 participant
@JuanAr