refactor TestMultiLangImport tests (#2128)

microsoft · Apr 29, 2020 · cd91bb0 · cd91bb0
1 parent 18cb982
commit cd91bb0
Showing 1 changed file with 59 additions and 32 deletions.
diff --git a/libraries/botbuilder-dialogs-adaptive/tests/LGGenerator.test.js b/libraries/botbuilder-dialogs-adaptive/tests/LGGenerator.test.js
@@ -45,38 +45,65 @@ describe('LGLanguageGenerator', function() {
         assert.throws(() => {lg.generate(context, '${tesdfdfsst()}', undefined);}, Error);
     });
 
-    it('TestMultiLangImport', async function() {
-        const lgResourceGroup = await LanguageResourceLoader.groupByLocale(resourceExplorer);
-
-        let resource = await resourceExplorer.getResource('a.en-US.lg');
-        const generator = new TemplateEngineLanguageGenerator(resource.fullName, lgResourceGroup);
-        let result = await generator.generate(getTurnContext(), '${templatea()}', undefined);
-        assert.strictEqual(result, 'from a.en-us.lg');
-
-        result = await generator.generate(getTurnContext(), '${templateb()}', undefined);
-        assert.strictEqual(result, 'from b.en-us.lg');
-
-        result = await generator.generate(getTurnContext(), '${templatec()}', undefined);
-        assert.strictEqual(result, 'from c.en.lg');
-
-        assert.throws(() => {generator.generate(getTurnContext(), '${greeting()}', undefined);}, Error);
-
-        resource = await resourceExplorer.getResource('a.lg');
-        const generator1 = new TemplateEngineLanguageGenerator(resource.fullName, lgResourceGroup);
-
-        result = await generator1.generate(getTurnContext(), '${templatea()}', undefined);
-        assert.strictEqual(result, 'from a.lg');
-
-        result = await generator1.generate(getTurnContext(), '${templateb()}', undefined);
-        assert.strictEqual(result, 'from b.lg');
-
-        result = await generator1.generate(getTurnContext(), '${templatec()}', undefined);
-        assert.strictEqual(result, 'from c.lg');
-
-        result = await generator1.generate(getTurnContext(), '${greeting()}', undefined);
-        assert.strictEqual(result, 'hi');
-
-
+    describe('TestMultiLangImport', () => {
+        let lgResourceGroup;
+        this.beforeAll(async function() {
+            lgResourceGroup = await LanguageResourceLoader.groupByLocale(resourceExplorer);
+        });
+        describe('Test MultiLang Import with specified locale', async function() {
+            let generator;
+            this.beforeAll(async function() {
+                const resource = await resourceExplorer.getResource('a.en-US.lg');
+                generator = new TemplateEngineLanguageGenerator(resource.fullName, lgResourceGroup);
+            });
+
+            it('"${templatea()}", no data', async () => {
+                const result = await generator.generate(getTurnContext(), '${templatea()}', undefined);
+                assert.strictEqual(result, 'from a.en-us.lg');
+            });
+
+            it('"${templateb()}", no data', async () => {
+                const result = await generator.generate(getTurnContext(), '${templateb()}', undefined);
+                assert.strictEqual(result, 'from b.en-us.lg');
+            });
+
+            it('"${templatec()}", no data', async () => {
+                const result = await generator.generate(getTurnContext(), '${templatec()}', undefined);
+                assert.strictEqual(result, 'from c.en.lg');
+            });
+
+            it('should throw for missing template: "${greeting()}", no data', async () => {
+                assert.throws(() => {generator.generate(getTurnContext(), '${greeting()}', undefined);}, Error);
+            });       
+        });
+
+        describe('Test Multi-Language Import with no locale', function() {   
+            let generator; 
+            this.beforeAll(async function() {
+                const resource = await resourceExplorer.getResource('a.lg');
+                generator = new TemplateEngineLanguageGenerator(resource.fullName, lgResourceGroup);
+            });
+
+            it('"${templatea()}", no data', async () => {
+                const result = await generator.generate(getTurnContext(), '${templatea()}', undefined);
+                assert.strictEqual(result, 'from a.lg');
+            });
+
+            it('"${templateb()}", no data', async () => {
+                const result = await generator.generate(getTurnContext(), '${templateb()}', undefined);
+                assert.strictEqual(result, 'from b.lg');
+            });
+
+            it('"${templatec()}", no data', async () => {
+                const result = await generator.generate(getTurnContext(), '${templatec()}', undefined);
+                assert.strictEqual(result, 'from c.lg');
+            });
+
+            it('"${greeting()}", no data', async () => {
+                const result = await generator.generate(getTurnContext(), '${greeting()}', undefined);
+                assert.strictEqual(result, 'hi');
+            });    
+        });
     });
 
     describe('TestMultiLangGenerator', () => {