Skip to content

Commit

Permalink
Add @microsoft/api-extractor to detect public API changes (#1962)
Browse files Browse the repository at this point in the history
* add @microsoft/api-extractor to botbuilder-core

* add api-extractor to libraries

* run api-extractor on all libs except for:
 * botframework-connector
 * adaptive-expressions (in preview)
 * botbuilder-lg (in preview)

* support friendlier jsonc render on GitHub

* bump @microsoft/api-extractor to ^7.7.12 b/c microsoft/rushstack/issues/1095

* regenerate bf-schema.api.md after master merge

* add codeowners, regen core & dialogs api.md

* regenerate botbuilder.api.md after merging master
  • Loading branch information
stevengum authored Apr 20, 2020
1 parent 73a63b5 commit 57ad046
Show file tree
Hide file tree
Showing 41 changed files with 8,589 additions and 75 deletions.
10 changes: 9 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# .gitattributes in project root
package.json text eol=lf
package-lock.json text eol=lf
package-lock.json text eol=lf

# Rush's JSON config files use JavaScript-style code comments. The rule below prevents pedantic
# syntax highlighters such as GitHub's from highlighting these comments as errors. Your text editor
# may also require a special configuration to allow comments in JSON.
#
# For more information, see this issue: https://github.com/microsoft/rushstack/issues/1088
#
*.json linguist-language=JSON-with-Comments
6 changes: 6 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# For all public API changes
/libraries/*/etc/* @benbrown @stevengum @stevenic

# For maintenance of shipped packages dependencies and devDependencies
# Codeowners should use tools such as https://bundlephobia.com/
/libraries/*/package.json @benbrown @stevengum @stevenic
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
libraries/functional-tests/**/lib
libraries/functional-tests/**/*.vscode/launch.json

# @microsoft/api-extractor
libraries/*/temp
libraries/*/dist

# User-specific files
*.suo
*.user
Expand Down
11 changes: 6 additions & 5 deletions libraries/adaptive-expressions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,21 @@
"moment-timezone": "^0.5.25"
},
"devDependencies": {
"@microsoft/api-extractor": "^7.7.12",
"@types/jspath": "^0.4.0",
"@types/mocha": "^5.2.5",
"@types/node": "^10.12.18",
"mocha": "^5.2.0",
"nyc": "^15.0.0",
"ts-node": "^4.1.0",
"typescript": "3.5.3",
"mocha": "^5.2.0"
"typescript": "3.5.3"
},
"scripts": {
"build": "tsc",
"test": "tsc && mocha tests/ --timeout 60000",
"clean": "erase /q /s .\\lib",
"build-docs": "typedoc --theme markdown --entryPoint adaptive-expressions --excludePrivate --includeDeclarations --ignoreCompilerErrors --module amd --out ..\\..\\doc\\adaptive-expressions .\\lib\\index.d.ts --hideGenerator --name \"Bot Builder SDK - Expression\" --readme none",
"set-version": "npm version --allow-same-version ${Version}"
"clean": "erase /q /s .\\lib",
"set-version": "npm version --allow-same-version ${Version}",
"test": "tsc && mocha tests/ --timeout 60000"
},
"files": [
"/lib",
Expand Down
Loading

0 comments on commit 57ad046

Please sign in to comment.