Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@munozemilio
Copy link
Contributor

Fixes #

Description

Specific Changes

Testing

Chris McConnell and others added 30 commits September 19, 2020 21:56
use nuget.config
…#4668)

The following third party libraries that do not have strong names:
NAudio
Twilio
Thrzn41.WebexTeams
updated reference version of Microsoft.BotFramework.Orchestrator
Add description to memory assertions.
Redo retries tests to work with new retries model.
Hide DialogInspector and centralize resetting retries
* fix DafaultValueResponce can't access dc.state

* add adaptive test for NumberInput default response

* fix BindAsync wrong signature in OAuthInput

* defense explicitly cancellationToken in BindAsync

* add cancellationToken in EndDialogAsync
* Enable custom AttachmentInput dialogs.

* Add positive and negative tests for custom AttachmentInput
…ail (#4719)

* Add AUTOMATEDBUILD precompiler directive, change Assert.Inconclusive() to Assert.Fail

* Fix DefineConstants in Microsoft.Bot.Builder.FunctionalTests.csproj

* Fix environment vars for dotnet test

* Set twilio env vars

* Fix linux yaml
…4604)

* fix DSM tryGetValue

* add more tests

* resolve conflicts
* Refactored FacebookAdapter to add a virtual metho for FB message creation that allows the devs to manipulate the FB message instanc before it gets sent to Facebook.
Added FacebookAdapterWithTag adapter to FB test bot so we can add the "ACCOUNT_UPDATE" tag as defined in https://developers.facebook.com/docs/messenger-platform/send-messages/message-tags#sending

* Fixed errors in DialogStateManagerTests

* Added missing MessagingType property.
* init LG debugger

* change LGEvent to Custom

* fix ci error

* fix ci error
* redo the default fallback of namespace

* fix issue

* make inject function case sensitive
* Update BotFrameworkAdapter to fix Fixes: #4710

Fixes #4710 by using Convert.Int32 instead of (int) , to avoid cast exception System.InvalidCastException - Unable to cast object of type ‘System.Int64’ to type ‘System.Int32

* Updated for culture sensitive method calls

Include reference to System.Globalization.CultureInfo.InvariantCulture in method call.
* Add check for DisableApiCompatibityValidation

* Add quotes to "true"

* Add comment
* Change Assert.Inconclusive() to Assert.Fail()

* Add #if !AUTOMATEDBUILD

* Add var TESTAPPID

* Move env vars to dotnet test task

* Change env var name to TestPassword

* Add TestAppId: $(LinuxTestBotAppId)
* Refactor of Microsoft.Bot.Builder.Azure.Queues.

* Moving QueueStorage to TurnState.

* Add visibility timeout.

* Changes requested by peer review.

* Remove references to Dialogs.Declarative.
EricDahlvang and others added 5 commits October 21, 2020 14:00
…s' to 'last wins' (#4824)

* Debugging: Move from first win to last wins, interface converter now has a non-concurrent dictionary and default source map is nullsourcemap

* Undo source map change

* Declarative: Remove JToken cloning due to JSOn.NET bug
* remove trusted service url check in appcredentials

* cr feedback

* cr feedback
Removed the skills functional tests, I was the only one using them and decided to remove them to avoid clutter.
New versions of these test projects will be eventually in https://github.com/microsoft/BotFramework-FunctionalTests
For the time being, these projects can be found in this fork if anyone needs them: https://github.com/gabogorg/botbuilder-dotnet
@munozemilio munozemilio requested a review from a team as a code owner October 23, 2020 04:20
@munozemilio munozemilio requested review from axelsrz and cleemullins and removed request for a team and cleemullins October 23, 2020 04:20
@munozemilio munozemilio merged commit 87fc2b1 into lu-parser Oct 23, 2020
@munozemilio munozemilio deleted the emimunoz/lu_parser_tests branch October 23, 2020 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.