Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Change Assert.Inconclusive() to Assert.Fail() in tests #4754

Merged
BruceHaley merged 6 commits into from
Oct 6, 2020
Merged

Change Assert.Inconclusive() to Assert.Fail() in tests #4754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1ac6dc
Change Assert.Inconclusive() to Assert.Fail()
Oct 5, 2020
a9d7d08
Add #if !AUTOMATEDBUILD
Oct 5, 2020
374cc73
Add var TESTAPPID
Oct 5, 2020
a8f4778
Move env vars to dotnet test task
Oct 5, 2020
57d3d8a
Change env var name to TestPassword
Oct 5, 2020
ef5c247
Add TestAppId: $(LinuxTestBotAppId)
Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FunctionalTests/Microsoft.Bot.Builder.FunctionalTests/Configuration/EnvironmentConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public static string TestAppId()
var testAppId = Environment.GetEnvironmentVariable("TESTAPPID");
if (string.IsNullOrWhiteSpace(testAppId))
{
Assert.Inconclusive("Environment variable 'TestAppId' not found.");
Assert.Fail("Environment variable 'TestAppId' not found.");
}

return testAppId;
Expand All @@ -27,7 +27,7 @@ public static string TestAppPassword()

if (string.IsNullOrWhiteSpace(testPassword))
{
Assert.Inconclusive("Environment variable 'TestPassword' not found.");
Assert.Fail("Environment variable 'TestPassword' not found.");
}

return testPassword;
Expand Down
3 changes: 3 additions & 0 deletions FunctionalTests/Microsoft.Bot.Builder.FunctionalTests/GetTokenRefreshTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ namespace Microsoft.Bot.Builder.FunctionalTests
{
[TestClass]
[TestCategory("FunctionalTests")]
#if !AUTOMATEDBUILD
[Ignore]
#endif
public class GetTokenRefreshTests
{
private string testAppId = null;
Expand Down
3 changes: 3 additions & 0 deletions build/yaml/botbuilder-dotnet-functional-test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ steps:
projects: '$(System.DefaultWorkingDirectory)\FunctionalTests\**\*FunctionalTests.csproj'
arguments: '-v n --configuration $(BuildConfiguration) --filter "TestCategory=FunctionalTests&TestCategory!=Adapters" --collect:"Code Coverage" --settings $(System.DefaultWorkingDirectory)\CodeCoverage.runsettings '
workingDirectory: '$(System.DefaultWorkingDirectory)\'
env:
TestAppId: $(LinuxTestBotAppId)
TestPassword: $(LinuxTestBotAppSecret)

- task: AzureCLI@1
displayName: 'Delete test resource group'
Expand Down
3 changes: 3 additions & 0 deletions build/yaml/botbuilder-dotnet-functional-test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ steps:
projects: '$(System.DefaultWorkingDirectory)\FunctionalTests\**\*FunctionalTests.csproj'
arguments: '-v n --configuration $(BuildConfiguration) --filter "TestCategory=FunctionalTests&TestCategory!=Adapters"'
workingDirectory: tests
env:
TestAppId: $(WinTestBotAppId)
TestPassword: $(WinTestBotAppSecret)

- task: AzureCLI@1
displayName: 'Delete Resources'
Expand Down