Make missing test environment vars cause a functional test build to fail

Directory.Build.props

@@ -48,6 +48,10 @@
     <DefineConstants>SIGNASSEMBLY</DefineConstants>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(TF_BUILD)'=='True' ">
+    <DefineConstants>$(DefineConstants);AUTOMATEDBUILD</DefineConstants>
+  </PropertyGroup>
+
   <PropertyGroup>
     <!-- Rules found at: https://aka.ms/Microsoft-NuGet-Compliance -->
     <PackageProjectUrl>https://github.com/Microsoft/botbuilder-dotnet</PackageProjectUrl>

FunctionalTests/Microsoft.Bot.Builder.FunctionalTests/DirectLineClientTests.cs

@@ -11,6 +11,9 @@ namespace Microsoft.Bot.Builder.FunctionalTests
 {
     [TestClass]
     [TestCategory("FunctionalTests")]
+#if !AUTOMATEDBUILD
+    [Ignore]
+#endif
     public class DirectLineClientTests
     {
         private static string directLineSecret = null;
@@ -114,13 +117,13 @@ private void GetEnvironmentVars()
                 directLineSecret = Environment.GetEnvironmentVariable("DIRECTLINE");
                 if (string.IsNullOrWhiteSpace(directLineSecret))
                 {
-                    Assert.Inconclusive("Environment variable 'DIRECTLINE' not found.");
+                    Assert.Fail("Environment variable 'DIRECTLINE' not found.");
                 }
 
                 botId = Environment.GetEnvironmentVariable("BOTID");
                 if (string.IsNullOrWhiteSpace(botId))
                 {
-                    Assert.Inconclusive("Environment variable 'BOTID' not found.");
+                    Assert.Fail("Environment variable 'BOTID' not found.");
                 }
             }
         }

FunctionalTests/Microsoft.Bot.Builder.FunctionalTests/DirectLineSpeechTests.cs

@@ -19,7 +19,6 @@
 namespace Microsoft.Bot.Builder.FunctionalTests
 {
     [TestClass]
-
     [TestCategory("FunctionalTests")]
     [Ignore("DirectLine Speech tests require updates to the REST API and CLI to be able to properly provision a bot.")]
     public class DirectLineSpeechTests
@@ -91,14 +90,14 @@ private void GetEnvironmentVars()
             speechBotSecret = Environment.GetEnvironmentVariable("SPEECHBOTSECRET");
             if (string.IsNullOrWhiteSpace(speechBotSecret))
             {
-                Assert.Inconclusive("Environment variable 'SPEECHBOTSECRET' not found.");
+                Assert.Fail("Environment variable 'SPEECHBOTSECRET' not found.");
             }
 
             // The cog services key for use with DLS.
             speechSubscription = Environment.GetEnvironmentVariable("SPEECHSUBSCRIPTION");
             if (string.IsNullOrWhiteSpace(speechSubscription))
             {
-                Assert.Inconclusive("Environment variable 'SPEECHSUBSCRIPTION' not found.");
+                Assert.Fail("Environment variable 'SPEECHSUBSCRIPTION' not found.");
             }
         }
 

FunctionalTests/Microsoft.Bot.Builder.FunctionalTests/FacebookChatTests.cs

@@ -13,6 +13,9 @@ namespace Microsoft.Bot.Builder.FunctionalTests
     [TestClass]
     [TestCategory("FunctionalTests")]
     [TestCategory("Adapters")]
+#if !AUTOMATEDBUILD
+    [Ignore]
+#endif
     public class FacebookChatTests
     {
         private const string FacebookUrlBase = "https://graph.facebook.com/v5.0";

FunctionalTests/Microsoft.Bot.Builder.FunctionalTests/SlackClientTest.cs

@@ -15,6 +15,9 @@ namespace Microsoft.Bot.Builder.FunctionalTests
     [TestClass]
     [TestCategory("FunctionalTests")]
     [TestCategory("Adapters")]
+#if !AUTOMATEDBUILD
+    [Ignore]
+#endif
     public class SlackClientTest
     {
         private const string SlackUrlBase = "https://slack.com/api";
@@ -136,31 +139,31 @@ private void GetEnvironmentVars()
                 _slackChannel = Environment.GetEnvironmentVariable("SlackChannel");
                 if (string.IsNullOrWhiteSpace(_slackChannel))
                 {
-                    Assert.Inconclusive("Environment variable 'SlackChannel' not found.");
+                    Assert.Fail("Environment variable 'SlackChannel' not found.");
                 }
 
                 _slackBotToken = Environment.GetEnvironmentVariable("SlackBotToken");
                 if (string.IsNullOrWhiteSpace(_slackBotToken))
                 {
-                    Assert.Inconclusive("Environment variable 'SlackBotToken' not found.");
+                    Assert.Fail("Environment variable 'SlackBotToken' not found.");
                 }
 
                 _slackClientSigningSecret = Environment.GetEnvironmentVariable("SlackClientSigningSecret");
                 if (string.IsNullOrWhiteSpace(_slackClientSigningSecret))
                 {
-                    Assert.Inconclusive("Environment variable 'SlackClientSigningSecret' not found.");
+                    Assert.Fail("Environment variable 'SlackClientSigningSecret' not found.");
                 }
 
                 _slackVerificationToken = Environment.GetEnvironmentVariable("SlackVerificationToken");
                 if (string.IsNullOrWhiteSpace(_slackVerificationToken))
                 {
-                    Assert.Inconclusive("Environment variable 'SlackVerificationToken' not found.");
+                    Assert.Fail("Environment variable 'SlackVerificationToken' not found.");
                 }
 
                 _botName = Environment.GetEnvironmentVariable("BotName");
                 if (string.IsNullOrWhiteSpace(_botName))
                 {
-                    Assert.Inconclusive("Environment variable 'BotName' not found.");
+                    Assert.Fail("Environment variable 'BotName' not found.");
                 }
             }
         }

FunctionalTests/Microsoft.Bot.Builder.FunctionalTests/TwilioNumberTests.cs

@@ -17,6 +17,9 @@ namespace Microsoft.Bot.Builder.FunctionalTests
     [TestClass]
     [TestCategory("FunctionalTests")]
     [TestCategory("Adapters")]
+#if !AUTOMATEDBUILD
+    [Ignore]
+#endif
     public class TwilioNumberTests
     {
         private string _botEndpoint;
@@ -101,31 +104,31 @@ private void GetEnvironmentVars()
                 _twilioNumber = Environment.GetEnvironmentVariable("TWILIO_NUMBER");
                 if (string.IsNullOrWhiteSpace(_twilioNumber))
                 {
-                    Assert.Inconclusive("Environment variable 'TwilioNumber' not found.");
+                    Assert.Fail("Environment variable 'TwilioNumber' not found.");
                 }
 
                 _twilioAuthToken = Environment.GetEnvironmentVariable("TWILIO_AUTH_TOKEN");
                 if (string.IsNullOrWhiteSpace(_twilioAuthToken))
                 {
-                    Assert.Inconclusive("Environment variable 'TWILIO_AUTH_TOKEN' not found.");
+                    Assert.Fail("Environment variable 'TWILIO_AUTH_TOKEN' not found.");
                 }
 
                 _twilioAccountSid = Environment.GetEnvironmentVariable("TWILIO_ACCOUNT_SID");
                 if (string.IsNullOrWhiteSpace(_twilioAccountSid))
                 {
-                    Assert.Inconclusive("Environment variable 'TWILIO_ACCOUNT_SID' not found.");
+                    Assert.Fail("Environment variable 'TWILIO_ACCOUNT_SID' not found.");
                 }
 
                 _senderNumber = Environment.GetEnvironmentVariable("SENDER_NUMBER");
                 if (string.IsNullOrWhiteSpace(_senderNumber))
                 {
-                    Assert.Inconclusive("Environment variable 'SENDER_NUMBER' not found.");
+                    Assert.Fail("Environment variable 'SENDER_NUMBER' not found.");
                 }
 
                 _botEndpoint = Environment.GetEnvironmentVariable("TwilioValidationUrl");
                 if (string.IsNullOrWhiteSpace(_botEndpoint))
                 {
-                    Assert.Inconclusive("Environment variable 'TwilioValidationUrl' not found.");
+                    Assert.Fail("Environment variable 'TwilioValidationUrl' not found.");
                 }
             }
         }

FunctionalTests/Microsoft.Bot.Builder.FunctionalTests/WebexClientTest.cs

@@ -17,6 +17,9 @@ namespace Microsoft.Bot.Builder.FunctionalTests
     [TestClass]
     [TestCategory("FunctionalTests")]
     [TestCategory("Adapters")]
+#if !AUTOMATEDBUILD
+    [Ignore]
+#endif
     public class WebexClientTest
     {        
         private const string WebexUrlBase = "https://api.ciscospark.com/v1";