Fix DialogStateMamager TryGetValue method throwing FormatException

libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs

@@ -120,7 +120,17 @@ public static bool TryGetPathValue<T>(object obj, string path, out T value)
                 }
             }
 
-            value = MapValueTo<T>(result);
+            try
+            {
+                value = MapValueTo<T>(result);
+            }
+#pragma warning disable CA1031 // Do not catch general exception types
+            catch (Exception)
+#pragma warning restore CA1031 // Do not catch general exception types
+            {
+                return false;
+            }
+
             return true;
         }
 

tests/Microsoft.Bot.Builder.Dialogs.Tests/DialogStateManagerTests.cs

@@ -312,6 +312,36 @@ await CreateDialogContext(async (dc, ct) =>
             }).StartTestAsync();
         }
 
+        [Fact]
+        public async Task TestTryGetValueWithWrongType()
+        {
+            await CreateDialogContext(async (dc, ct) =>
+            {
+                dc.State.SetValue("user.name.first", "joe");
+                Assert.Equal(false, dc.State.TryGetValue<int>("user.name.first", out var val));
+                Assert.Equal(true, dc.State.TryGetValue<string>("user.name.first", out var val2));
+                Assert.Equal("joe", val2);
+
+                dc.State.SetValue("user.age", 19);
+                Assert.Equal(true, dc.State.TryGetValue<string>("user.age", out var val3));
+                Assert.Equal("19", val3);
+                Assert.Equal(true, dc.State.TryGetValue<int>("user.age", out var val4));
+                Assert.Equal(19, val4);
+
+                dc.State.SetValue("user.salary", "10000");
+                Assert.Equal(true, dc.State.TryGetValue<string>("user.salary", out var val5));
+                Assert.Equal("10000", val5);
+                Assert.Equal(true, dc.State.TryGetValue<int>("user.salary", out var val6));
+                Assert.Equal(10000, val6);
+                dc.State.SetValue("user.foo", foo);
+
+                Assert.Equal(false, dc.State.TryGetValue<string>("user.foo", out var val7));
+                Assert.Equal(true, dc.State.TryGetValue<Foo>("user.foo", out var val8));
+                Assert.Equal(false, dc.State.TryGetValue<IDictionary<string, string>>("user.foo", out var val9));
+                Assert.Equal(true, dc.State.TryGetValue<Bar>("user.foo", out var val10));
+            }).StartTestAsync();
+        }
+
         [Fact]
         public async Task TestGetValueT()
         {