Merged
Conversation
PawelWMS
reviewed
Jul 13, 2022
PawelWMS
approved these changes
Jul 13, 2022
anphel31
approved these changes
Jul 13, 2022
mfrw
previously approved these changes
Jul 14, 2022
mfrw
reviewed
Jul 14, 2022
Contributor
|
My understanding is that the toolchain*.txt changes mean that this change should be marked as: Does this affect the toolchain? YES. Looks reasonable to me otherwise. |
danmihai1
approved these changes
Jul 14, 2022
mfrw
approved these changes
Jul 15, 2022
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/tools/cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
This PR removes the patch to
crypto/engine/eng_all.cin OpenSSL, introduced in #3182. This section of the patch was introduced to make loading the SymCrypt and KeysInUse engines more reliable; however, this code path caused extra errors to be generated during thetest_shlibloadandtest_includesunit tests.While the errors don't impact normal operation of OpenSSL, I am removing this code until the cause is understood. I have performed a full, clean rebuild of the OpenSSL package with
RUN_CHECK=yto confirm the issue no longer repros.Change Log
crypto/engine/eng_all.cfromSPECS/openssl/openssl-1.1.1-load-default-engines.patchDoes this affect the toolchain?
YES
Test Methodology
RUN_CHECK=y