Skip to content

Conversation

durgajagadeesh
Copy link
Contributor

@durgajagadeesh durgajagadeesh commented Sep 4, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

[High] Upgrade reaper for CVE-2025-9288
Astrolabe reference: https://brave-ocean-0baeae310.5.azurestaticapps.net/#/cve/CVE-2025-9288
Upstream patch reference: browserify/sha.js@f2a258e

Change Log
  • Modified file: reaper.spec
  • Modified file: reaper.signatures.json
  • Modified file: reaper_build_caches.sh
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@durgajagadeesh durgajagadeesh requested a review from a team as a code owner September 4, 2025 10:55
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels Sep 4, 2025
@durgajagadeesh durgajagadeesh marked this pull request as draft September 4, 2025 10:58
@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Sep 4, 2025

Hi,
This PR is ready for review, built successful in my local VM.
image

I have removed several outdated patches after confirming that their changes are already present in the newly generated tarball.
image

All patches have been applied cleanly.
image

And the CVE-2025-9288 fix has already been included in the latest tarball generated by the reaper_build_script.sh script.

Note: I have the below reaper.signature.json changes while this got success!
image

And build log from the local VM:
reaper-3.1.1-20.cm2.src.rpm-10-09-2025-success_build.log

-Thank you!

@durgajagadeesh durgajagadeesh marked this pull request as ready for review September 4, 2025 13:29
@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Sep 5, 2025

Hi,
I have completed the tests for reaper using the resultant rpm binary(reaper-3.1.1-20.cm2.x86_64.rpm).
Please find the reference screenshot below.

image image image image

Note: Reaper web interface at http://localhost:8080 is running successfully.
-Thank you!

@Malateshk007
Copy link

@realsdx, gentle reminder for review and sign-off if all good.!

@realsdx
Copy link
Contributor

realsdx commented Sep 8, 2025

/azurepipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@realsdx realsdx requested review from Sumynwa and removed request for realsdx September 9, 2025 14:12
@realsdx
Copy link
Contributor

realsdx commented Sep 10, 2025

On a fresh azurelinux system the script fails with this:
Screenshot 2025-09-10 114047

Please include nodejs-npm as well as the dependency in the script

Also, since you have improved the script, please copy all the tar files in the current working directory instead of copying to reaper_caches

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Sep 10, 2025

On a fresh azurelinux system the script fails with this: Screenshot 2025-09-10 114047

Please include nodejs-npm as well as the dependency in the script

Also, since you have improved the script, please copy all the tar files in the current working directory instead of copying to reaper_caches

Hi @realsdx ,
I have implemented the updates as you suggested, and the script is functioning correctly with these modifications.

image

If there’s anything else that needs to be updated, please let me know.
-Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack/2.0 PRs Destined for Azure Linux 2.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants