-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: extended repo LVBS kernel #12064
base: 3.0-dev
Are you sure you want to change the base?
Conversation
Great to see the start of this, @ddstreet! I know we're mutually interested in seeing an LVBS-enabled kernel make its way into the extended repo. Let us know when you're ready to start getting any early reviews/feedback on the PR. (I see it currently marked as WIP and draft.) I'm assuming @rlmenge, among others, will be keenly interested and have good suggestions. |
using # can unnecessarily confuse editors to think the rest of the line is a comment
|
||
make mrproper | ||
|
||
cp $CONFIG_FILE $KBUILD_OUTPUT/.config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking but will this work since the lvbs_normal
and lvbs_secure
directories have not been created yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits were super easy to follow, thank you! The logic makes sense to me but would want to validate in an rpmbuild environment to be sure all the KBUILD_OUTPUTs are operating as expected.
From what I gather with the spec is that it builds both secure and normal lvbs using the patches listed in the "kernel-lvbs.patches" and setting KBUILD_OUTPUT respectively. It then also builds Microsoft/skloader and Microsoft/initrd-sk.cpio.
A lot of the clean up work looks good to me such as making the config check its own function and reordering the manipulation of the config. Would just want again ensure the function is called as expected.
Just need to also update License files and Manifests similar to kernel-rt
and that will clear up the failing github checks
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
This is early work to build a kernel in the extended repo that includes LVBS support.
Note that the accumulated LVBS patches will be rolled into a dedicated LVBS kernel tarball, instead of carrying them as individual patches like this PR. Please ignore the actual content of the LVBS patches, as that content will be reviewed/managed by a kernel git branch (and this PR shouldn't be merged until that is complete and this is updated to use the resulting LVBS kernel tarball); this PR is intended only for review of the spec file (and related) changes.
Change Log
Add spec file, etc. to enable building LVBS kernel in extended repo
Does this affect the toolchain?
NO
Test Methodology
WIP, no testing/validation yet