Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled ccache and set ptest retries to 1 for PR checks (CP: #8503, #10133) #10392

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Sep 9, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Cherry-picking two PR check changes:

Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • PR check.

@PawelWMS PawelWMS requested review from a team as code owners September 9, 2024 23:14
@PawelWMS PawelWMS changed the title Enabling ccache and setting ptest retries to 1 for PR checks (CP: #8503, #10133) Enabled ccache and set ptest retries to 1 for PR checks (CP: #8503, #10133) Sep 9, 2024
@PawelWMS
Copy link
Contributor Author

PawelWMS commented Sep 9, 2024

Ignoring Go test coverage check - fixed in 3.0-dev, unrelated to this change.

@PawelWMS PawelWMS merged commit f97819a into fasttrack/3.0 Sep 9, 2024
13 of 17 checks passed
@PawelWMS PawelWMS deleted the pawelwi/enable_ccache_3.0_cp branch September 9, 2024 23:48
CBL-Mariner-Bot pushed a commit that referenced this pull request Sep 9, 2024
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants