This repository was archived by the owner on Feb 28, 2026. It is now read-only.
Throw more detailed error when compilation fails#18783
Merged
Charles-Gagnon merged 2 commits intomainfrom Mar 24, 2022
Merged
Conversation
alanrenmsft
reviewed
Mar 18, 2022
| recorder.record(61 /* CachedDataMissed */, cachedDataPath); | ||
| } | ||
| var script = new that._vm.Script(scriptSource, options); | ||
| var script; |
Contributor
There was a problem hiding this comment.
sql carbon edit comments?
Contributor
Author
There was a problem hiding this comment.
Oh right, let me wait and see if they accept my PR first.
Contributor
Author
There was a problem hiding this comment.
No word from them yet so just going to get this in and we can remove it later if they accept the change.
alanrenmsft
approved these changes
Mar 18, 2022
Pull Request Test Coverage Report for Build 2036324496
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #18781 - it took me a long time to track down where this failure was coming from because the error being thrown wasn't very useful :
Uncaught SyntaxError: Unexpected token '??'this will make it now display something like this
Uncaught Error: Error compiling file:///.../vs/workbench/browser/parts/editor/editorGroupView.js. SyntaxError: Unexpected token '??'PR for VS Code : microsoft/vscode-loader#37