Fixing the Vstest issue with Powershell GetItemProperty #21480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToreDemant
reviewed
Nov 25, 2025
| const versionArray = verSplitArray[1].split('.'); | ||
| if (versionArray.length !== 4) { | ||
|
|
||
| // PowerShell returns version directly, no need to split by '=' |
There was a problem hiding this comment.
This comment might be more confusing than helpful when change has been committed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where VsTest tasks fail on modern Windows systems due to using the deprecated wmic command.
Changes
Replace wmic command with PowerShell Get-ItemProperty cmdlet in VsTestV2 and VsTestV3
Update version parsing logic to handle direct version output from PowerShell
Add error handling with try-catch in PowerShell command
Improve version validation to accept minimum 3-part version numbers
Why This Change is Needed
wmic has been officially deprecated since Windows 10 21H1
wmic is no longer available on newer Windows systems including Server 2025
This causes VsTest tasks to fail with "Unable to locate executable file: 'wmic'" error
PowerShell Get-ItemProperty is the recommended modern alternative
Testing
Tested the PowerShell command manually on Windows systems
Verified that the new approach returns the same version information format
Confirmed error handling works properly for invalid file paths
Impact
Compatibility: Works on all Windows systems with PowerShell (virtually all modern Windows)
Reliability: More robust error handling and execution
Performance: Similar performance characteristics to the original implementation
Backward Compatibility: Maintains the same API and behavior for calling code
Fixes: Issue with VsTest tasks failing on systems without wmic