small ultility that helps team to get all names/ids they own. #20495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is the output for azure-artifacts-packages team
|
jmyersmsft
reviewed
Oct 1, 2024
.github/taskIdbyowner.py
Outdated
| import json | ||
|
|
||
| codeowners_file_path = '/workspaces/azure-pipelines-tasks/.github/CODEOWNERS' | ||
| team_name = '@microsoft/azure-artifacts-packages' |
There was a problem hiding this comment.
It would be nice to take this from the command line
.github/taskIdbyowner.py
Outdated
| import os | ||
| import json | ||
|
|
||
| codeowners_file_path = '/workspaces/azure-pipelines-tasks/.github/CODEOWNERS' |
There was a problem hiding this comment.
It would be better to not check in paths from your local machine. There are some nuances to it, but from pathlib import Path and Path(__file__).parent / 'CODEOWNERS' should get you close enough to what you need
.github/taskIdbyowner.py
Outdated
| return tasks | ||
|
|
||
| def extract_task_id(task_path): | ||
| task_json_path = os.path.join(task_path, 'task.json') |
There was a problem hiding this comment.
Because these paths are relative, you're making an assumption here that the script is being run from the root of the repository. It would be better to join the root of the repository, then the task_path, then task.json
merlynomsft
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just add a taskidowner.py script to extract all task names/ids owned by a team.