refactor: replace Q with native promises
#905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
commented
Jun 1, 2023
…t make use of Q as deprecated for now
|
The team decided to continue supporting both Q promises and native promises until the release of v5. I marked the methods that make use of the Q library as deprecated for now. |
JamieMagee
commented
Jun 15, 2023
node/mock-toolrunner.ts
Outdated
Comment on lines
266
to
269
| // Deprecated, use execAsync instead | ||
| // Exec - use for long running tools where you need to stream live output as it runs | ||
| // returns a promise with return code. | ||
| // |
There was a problem hiding this comment.
Please use the @deprecated JSDoc tag. Otherwise this will not be shown to users in the IDE. See https://jsdoc.app/tags-deprecated.html
JamieMagee
commented
Jun 19, 2023
Co-authored-by: Jamie Magee <[email protected]>
|
/azp run |
|
No commit pushedDate could be found for PR 905 in repo microsoft/azure-pipelines-task-lib |
tkasparek
approved these changes
Aug 9, 2023
KonstantinTyukalov
approved these changes
Aug 14, 2023
|
/azp run |
|
Commenter does not have sufficient privileges for PR 905 in repo microsoft/azure-pipelines-task-lib |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
KonstantinTyukalov
approved these changes
Aug 28, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
* refactor: replace `Q` with native promises * Changed how promises were deferred to fix failing tests * Bumped version to 5.0.0 * Switched to using promise constructors instead of custom Deferred class * Continue support of Q until the release of v5. Marked the methods that make use of Q as deprecated for now * Added JSDoc deprecation annotation * Updated version and changelog * Updated changelog message * Apply review suggestion Co-authored-by: Jamie Magee <[email protected]> * Tests for execAsync --------- Co-authored-by: Aleksandr Levochkin <[email protected]> Co-authored-by: Aleksandr Levochkin <[email protected]> Co-authored-by: Aleksandr Levockin (Akvelon INC) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only handles the
nodedirectory. There are still uses ofQunder thepowershelldirectory.