Skip to content

Replaced scp2-2022 library with ssh2-sftp-client#1189

Merged
v-mohithgc merged 1 commit into
microsoft:masterfrom
v-gayatrij:users/v-gayjaiswal/AnsibleFixes
Sep 11, 2023
Merged

Replaced scp2-2022 library with ssh2-sftp-client#1189
v-mohithgc merged 1 commit into
microsoft:masterfrom
v-gayatrij:users/v-gayjaiswal/AnsibleFixes

Conversation

@v-gayatrij
Copy link
Copy Markdown
Contributor

@v-gayatrij v-gayatrij commented Sep 6, 2023 •
edited
Loading

Task name: Ansible

Description:

  • Migrated from scp2-2022 library to ssh2-sftp-client
  • Downgraded ssh2 to 1.4.0

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

v-mohithgc
v-mohithgc approved these changes Sep 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@v-mohithgc v-mohithgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v-mohithgc v-mohithgc requested review from a user and LeftTwixWand September 6, 2023 14:50
@v-mohithgc v-mohithgc added Area:RM RM area of work; Owners: @rvairavelu @manolerazvan Improvement labels Sep 6, 2023
LeftTwixWand
LeftTwixWand approved these changes Sep 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@LeftTwixWand LeftTwixWand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

v-nagarajku
v-nagarajku reviewed Sep 11, 2023
View reviewed changes
Comment thread Extensions/Ansible/Src/Tasks/Ansible/task.json
v-nagarajku
v-nagarajku approved these changes Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@v-nagarajku v-nagarajku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v-mohithgc v-mohithgc merged commit 962d5f0 into microsoft:master Sep 11, 2023
@PavelPikat
Copy link
Copy Markdown

PavelPikat commented Sep 12, 2023

@v-gayatrij @LeftTwixWand @v-nagarajku this change broke the extension for us - we no longer able to copy files to remote VM.
Are there any changes required to Ansible playbooks and relative paths to make it work?

@v-gayatrij
Copy link
Copy Markdown
Contributor Author

v-gayatrij commented Sep 13, 2023 •
edited
Loading

@PavelPikat the issue will be resolved by version 0.228.1 which is out now. Please check and confirm back.

Also, request you to share complete debug logs of previous version(0.228.0) to v-gayjaiswal@microsoft.com

@v-mohithgc
Copy link
Copy Markdown
Contributor

v-mohithgc commented Sep 15, 2023

Hi @PavelPikat, can you please mail us the logs of failure run (ie 0.228.0)

@v-mohithgc v-mohithgc mentioned this pull request Oct 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilipsonJoseph PhilipsonJoseph Awaiting requested review from PhilipsonJoseph

3 more reviewers

@LeftTwixWand LeftTwixWand LeftTwixWand approved these changes

@v-nagarajku v-nagarajku v-nagarajku approved these changes

@v-mohithgc v-mohithgc v-mohithgc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v-gayatrij v-gayatrij

Labels

Area:RM RM area of work; Owners: @rvairavelu @manolerazvan Improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@v-gayatrij @PavelPikat @v-mohithgc @LeftTwixWand @v-nagarajku