Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate HTML report implementation #4

Merged
merged 7 commits into from
Jun 10, 2019
Merged

generate HTML report implementation #4

merged 7 commits into from
Jun 10, 2019

Conversation

karanjitsingh
Copy link
Contributor

@karanjitsingh karanjitsingh commented Jun 6, 2019 •
edited
Loading

Moved ITelemetryDataCollector to Model
Html report creation implementation.
Rename ICLIArgs to IPublisherConfiguration
Add SourceDirectory to IPublisherConfiguration

Use IPublisherConfiguration object in parsers instead of getting individual values.

Ignore L1 test WillGenerateHTMLReport due to bug in ReportGenerator, see danielpalme/ReportGenerator#253

acesiddhu
acesiddhu reviewed Jun 6, 2019
View reviewed changes
nuget.config Show resolved Hide resolved
@karanjitsingh
Copy link
Contributor Author

@acesiddhu build not getting queued

@acesiddhu acesiddhu closed this Jun 6, 2019
@acesiddhu acesiddhu reopened this Jun 6, 2019
@acesiddhu
Copy link
Contributor

i deleted the definition on dtatestngint and thats what it is showing as pending :\

@acesiddhu
Copy link
Contributor

ok fixed it

@cltshivash
Copy link 

        CoverageReportParser parser = new CoverageReportParser(1, new string[] { }, new DefaultFilter(new string[] { }),

sourcedirectory././?

Refers to: src/CoveragePublisher/Parsers/ReportGeneratorParser.cs:94 in 12b876b. [](commit_id = 12b876b, deletion_comment = False)

cltshivash
cltshivash approved these changes Jun 10, 2019
View reviewed changes
Copy link

@cltshivash cltshivash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@karanjitsingh karanjitsingh merged commit c61588b into microsoft:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acesiddhu acesiddhu acesiddhu left review comments

@cltshivash cltshivash cltshivash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanjitsingh @acesiddhu @cltshivash