-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(axe-core-4.0.1): bump axe-core from 3.5.5 to 4.0.1 #366
Changes from 2 commits
fde5464
7e505a7
4eeeba0
b6bb988
cba7ec7
9995714
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
}, | ||
"dependencies": { | ||
"@types/sarif": ">=2.1.1 <=2.1.2", | ||
"axe-core": "^3.2.2", | ||
"axe-core": "^4.0.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We actually don't generally update this (that's why it's still back at 3.2.2), since we don't want to force users to update axe-core in order to update our library (it would have been better for us to use a |
||
"yargs": "^15.0.2" | ||
}, | ||
"devDependencies": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
[ | ||
{ | ||
"inapplicable": [], | ||
"incomplete": [], | ||
"passes": [], | ||
"testEngine": { | ||
"name": "axe-core", | ||
"version": "4.0.1" | ||
}, | ||
"testEnvironment": { | ||
"orientationAngle": 0, | ||
"orientationType": "landscape-primary", | ||
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/84.0.4147.125 Safari/537.36", | ||
"windowHeight": 600, | ||
"windowWidth": 800 | ||
}, | ||
"testRunner": { | ||
"name": "axe" | ||
}, | ||
"timestamp": "2020-08-10T23:42:05.017Z", | ||
"toolOptions": { | ||
"reporter": "v1", | ||
"runOnly": { | ||
"type": "rule", | ||
"values": [ | ||
"document-title" | ||
] | ||
} | ||
}, | ||
"url": "file:///C:/Users/davetryon/source/repos/axe-sarif-converter/master/src/test-resources/basic.html", | ||
"violations": [ | ||
{ | ||
"description": "Ensures each HTML document contains a non-empty <title> element", | ||
"help": "Documents must have <title> element to aid in navigation", | ||
"helpUrl": "https://dequeuniversity.com/rules/axe/4.0/document-title?application=webdriverjs", | ||
"id": "document-title", | ||
"impact": "serious", | ||
"nodes": [ | ||
{ | ||
"all": [], | ||
"any": [ | ||
{ | ||
"data": null, | ||
"id": "doc-has-title", | ||
"impact": "serious", | ||
"message": "Document does not have a non-empty <title> element", | ||
"relatedNodes": [] | ||
} | ||
], | ||
"failureSummary": "Fix any of the following:\n Document does not have a non-empty <title> element", | ||
"html": "<html class=\"deque-axe-is-ready\"><head></head><body>\n</body><script>document.documentElement.classList.add(\"deque-axe-is-ready\");</script></html>", | ||
"impact": "serious", | ||
"none": [], | ||
"target": [ | ||
"html" | ||
] | ||
} | ||
], | ||
"tags": [ | ||
"cat.text-alternatives", | ||
"wcag2a", | ||
"wcag242", | ||
"ACT" | ||
] | ||
} | ||
] | ||
} | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
[ | ||
{ | ||
"id": "document-title", | ||
"result": "failed", | ||
"pageLevel": false, | ||
"impact": "serious", | ||
"tags": [ | ||
"cat.text-alternatives", | ||
"wcag2a", | ||
"wcag242", | ||
"ACT" | ||
], | ||
"description": "Ensures each HTML document contains a non-empty <title> element", | ||
"help": "Documents must have <title> element to aid in navigation", | ||
"helpUrl": "https://dequeuniversity.com/rules/axe/4.0/document-title?application=axe-puppeteer", | ||
"inapplicable": [], | ||
"passes": [], | ||
"incomplete": [], | ||
"violations": [ | ||
{ | ||
"any": [ | ||
{ | ||
"id": "doc-has-title", | ||
"data": null, | ||
"relatedNodes": [], | ||
"impact": "serious", | ||
"message": "Document does not have a non-empty <title> element" | ||
} | ||
], | ||
"all": [], | ||
"none": [], | ||
"node": { | ||
"selector": [ | ||
"html" | ||
], | ||
"source": "<html><head></head><body>\n</body></html>", | ||
"xpath": [ | ||
"/html" | ||
], | ||
"ancestry": [ | ||
"html" | ||
] | ||
}, | ||
"impact": "serious", | ||
"result": "failed" | ||
} | ||
] | ||
} | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
{ | ||
"testEngine": { | ||
"name": "axe-core", | ||
"version": "4.0.1" | ||
}, | ||
"testRunner": { | ||
"name": "axe" | ||
}, | ||
"testEnvironment": { | ||
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/83.0.4103.0 Safari/537.36", | ||
"windowWidth": 800, | ||
"windowHeight": 600, | ||
"orientationAngle": 0, | ||
"orientationType": "portrait-primary" | ||
}, | ||
"timestamp": "2000-01-02T03:04:05.006Z", | ||
"url": "http://localhost/", | ||
"toolOptions": { | ||
"xpath": true, | ||
"runOnly": { | ||
"type": "rule", | ||
"values": [ | ||
"document-title" | ||
] | ||
}, | ||
"reporter": "v1" | ||
}, | ||
"violations": [ | ||
{ | ||
"id": "document-title", | ||
"impact": "serious", | ||
"tags": [ | ||
"cat.text-alternatives", | ||
"wcag2a", | ||
"wcag242", | ||
"ACT" | ||
], | ||
"description": "Ensures each HTML document contains a non-empty <title> element", | ||
"help": "Documents must have <title> element to aid in navigation", | ||
"helpUrl": "https://dequeuniversity.com/rules/axe/4.0/document-title?application=axe-puppeteer", | ||
"nodes": [ | ||
{ | ||
"any": [ | ||
{ | ||
"id": "doc-has-title", | ||
"data": null, | ||
"relatedNodes": [], | ||
"impact": "serious", | ||
"message": "Document does not have a non-empty <title> element" | ||
} | ||
], | ||
"all": [], | ||
"none": [], | ||
"impact": "serious", | ||
"html": "<html><head></head><body>\n</body></html>", | ||
"target": [ | ||
"html" | ||
], | ||
"xpath": [ | ||
"/html" | ||
], | ||
"failureSummary": "Fix any of the following:\n Document does not have a non-empty <title> element" | ||
} | ||
] | ||
} | ||
], | ||
"passes": [], | ||
"incomplete": [], | ||
"inapplicable": [] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
{ | ||
"testEngine": { | ||
"name": "axe-core", | ||
"version": "4.0.1" | ||
}, | ||
"testRunner": { | ||
"name": "axe" | ||
}, | ||
"testEnvironment": { | ||
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/83.0.4103.0 Safari/537.36", | ||
"windowWidth": 800, | ||
"windowHeight": 600, | ||
"orientationAngle": 0, | ||
"orientationType": "portrait-primary" | ||
}, | ||
"timestamp": "2000-01-02T03:04:05.006Z", | ||
"url": "http://localhost/", | ||
"toolOptions": { | ||
"xpath": true, | ||
"runOnly": { | ||
"type": "rule", | ||
"values": [ | ||
"document-title" | ||
] | ||
}, | ||
"reporter": "v2" | ||
}, | ||
"violations": [ | ||
{ | ||
"id": "document-title", | ||
"impact": "serious", | ||
"tags": [ | ||
"cat.text-alternatives", | ||
"wcag2a", | ||
"wcag242", | ||
"ACT" | ||
], | ||
"description": "Ensures each HTML document contains a non-empty <title> element", | ||
"help": "Documents must have <title> element to aid in navigation", | ||
"helpUrl": "https://dequeuniversity.com/rules/axe/4.0/document-title?application=axe-puppeteer", | ||
"nodes": [ | ||
{ | ||
"any": [ | ||
{ | ||
"id": "doc-has-title", | ||
"data": null, | ||
"relatedNodes": [], | ||
"impact": "serious", | ||
"message": "Document does not have a non-empty <title> element" | ||
} | ||
], | ||
"all": [], | ||
"none": [], | ||
"impact": "serious", | ||
"html": "<html><head></head><body>\n</body></html>", | ||
"target": [ | ||
"html" | ||
], | ||
"xpath": [ | ||
"/html" | ||
] | ||
} | ||
] | ||
} | ||
], | ||
"passes": [], | ||
"incomplete": [], | ||
"inapplicable": [] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The part earlier in the sentence where it says
^3.2.0
should be updated too, I'd suggest "version ^3.2.0 || ^4.0.0"