Partial fix for 960 #963
Merged
Partial fix for 960 #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
===========================================
+ Coverage 26.63% 38.00% +11.37%
===========================================
Files 28 28
Lines 3777 3815 +38
Branches 858 911 +53
===========================================
+ Hits 1006 1450 +444
+ Misses 2700 2239 -461
- Partials 71 126 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeibinLi
reviewed
Dec 13, 2023
|
The added lines are not covered by test. |
Right. @afourney could you also add a test to cover the added code? Code coverage will be decreased otherwise. |
|
@qingyun-wu @sonichi I have added test coverage. |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Partial fix for 960 * Fixed a missing = None * Added test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Partial fix for #960. Make
agentsoptional in many GroupChat help functions. Default to all agents (i.e.,self.agents)Related issue number
#960
Checks