-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dotnet] Add dotnet build workflow #946
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
=======================================
Coverage 30.14% 30.14%
=======================================
Files 30 30
Lines 4020 4020
Branches 908 908
=======================================
Hits 1212 1212
Misses 2729 2729
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just curious does this allow C# program to use this package? |
Looks good to me. Rust and Golang integration would be lovely too. |
Co-authored-by: Chi Wang <[email protected]>
Added back dotnet environment. @LittleLittleCloud does this environment needs to have API keys? |
Yes, some tests need openai keys to run, I'll add them later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions about the change in the existing worflow.
* update * update doc --------- Co-authored-by: “skzhang1” <“[email protected]”>
* update * add openai workflow * Update pre-commit.yml * Update run_openai_test_and_notebooks.yml * Update pre-commit.yml * Update .github/workflows/pre-commit.yml Co-authored-by: Chi Wang <[email protected]> * Update run_openai_test_and_notebooks.yml * Update run_openai_test_and_notebooks.yml * Update run_openai_test_and_notebooks.yml * Update pre-commit.yml * Update .pre-commit-config.yaml --------- Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
Why are these changes needed?
Add build/test/notebook test workflow for dotnet AutoGen package which will be introduced by #924
Related issue number
Checks