-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MATH tests to testbed #914
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
=======================================
Coverage 26.54% 26.54%
=======================================
Files 28 28
Lines 3805 3805
Branches 865 865
=======================================
Hits 1010 1010
Misses 2724 2724
Partials 71 71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks. Looks great from what I can see. I'll formally test and review this ASAP. |
Looks good. I was able to get everything to run. As we onboard more benchmarks, I might do some modifications to how requirements files are handled, but that's for a later time. I left a few comments. Address them, and I'll approve. |
@afourney I didn't see any comments in the PR. Where do you put them? |
@kevin666aa You don't see 4 comments in this thread? What about via this link: https://github.com/microsoft/autogen/pull/914/files/3f22352755910ce88178731d71c322dfc67e6b36 |
Emm.. This is so weird, I just don't see any comments, even through the link. Update: Asked @skzhang1, he cannot see it either. |
@kevin666aa That's so weird. Here are my comments: |
You need to submit your comments. |
Today I learned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update looks good. Approved |
* add MATH eval to testbed * update --------- Co-authored-by: Qingyun Wu <[email protected]>
* added documentation about small time budget * small change for better clarity * Update website/docs/Use-Cases/Task-Oriented-AutoML.md Co-authored-by: Chi Wang <[email protected]> --------- Co-authored-by: Chi Wang <[email protected]>
* add MATH eval to testbed * update --------- Co-authored-by: Qingyun Wu <[email protected]>
Why are these changes needed?
Add 17 level-5 problems from MATH to testbed.
Related issue number
Checks