Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GroupChat to receive messages from outside. #912

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

afourney
Copy link
Member

@afourney afourney commented Dec 7, 2023

Why are these changes needed?

If GroupChat was initiated by an external agent (not a member of the group chat), and next_agent was called, it would crash with a ValueError, due to the agent not being present. This PR fixes that issue.

It also adds some much-needed tests for next_agent.

Related issue number

N/A

Checks

@sonichi sonichi added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 4324b27 Dec 8, 2023
76 of 84 checks passed
@sonichi sonichi deleted the group_chat_outsiders branch December 9, 2023 22:14
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
@afourney afourney added the gaia label Jan 10, 2024
@afourney afourney mentioned this pull request Feb 4, 2024
3 tasks
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group chat/teams group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants