Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment to explain the role of UNSTRUCTURED_FORMATS #909

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

thinkall
Copy link
Collaborator

@thinkall thinkall commented Dec 7, 2023

Why are these changes needed?

Address #891

Related issue number

Closes #891

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b4fb8f) 26.58% compared to head (7c49000) 30.68%.

❗ Current head 7c49000 differs from pull request most recent head 7855c4b. Consider uploading reports for the commit 7855c4b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
+ Coverage   26.58%   30.68%   +4.09%     
==========================================
  Files          28       28              
  Lines        3732     3732              
  Branches      847      847              
==========================================
+ Hits          992     1145     +153     
+ Misses       2667     2502     -165     
- Partials       73       85      +12     
Flag Coverage Δ
unittests 30.68% <ø> (+4.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkall
Copy link
Collaborator Author

thinkall commented Dec 7, 2023

@szwang-seedtech, does the comment added in this PR make the code clearer for you?

@sonichi sonichi added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit cf2ecf9 Dec 8, 2023
76 of 84 checks passed
@sonichi sonichi deleted the fix_unstructured branch December 9, 2023 20:06
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
)

* Add a comment to explain the role of UNSTRUCTURED_FORMATS

* Update comments
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
)

* Add a comment to explain the role of UNSTRUCTURED_FORMATS

* Update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formats in retrieve_utils.py
4 participants