Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache if cost not calculated #903

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Update cache if cost not calculated #903

merged 2 commits into from
Dec 7, 2023

Conversation

yiranwu0
Copy link
Collaborator

@yiranwu0 yiranwu0 commented Dec 7, 2023

Why are these changes needed?

Update cache if cost not calculated, as in #883

Related issue number

Closes #883

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (31c1664) 25.24% compared to head (cdd854f) 62.70%.

Files Patch % Lines
autogen/oai/client.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #903       +/-   ##
===========================================
+ Coverage   25.24%   62.70%   +37.45%     
===========================================
  Files          28       28               
  Lines        3728     3732        +4     
  Branches      848      889       +41     
===========================================
+ Hits          941     2340     +1399     
+ Misses       2710     1145     -1565     
- Partials       77      247      +170     
Flag Coverage Δ
unittests 62.48% <40.00%> (+37.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit cbd1e19 Dec 7, 2023
84 checks passed
@sonichi sonichi deleted the fixcost branch December 7, 2023 15:07
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
* update cost for cache

* fix test
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* update cost for cache

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'ChatCompletion' object has no attribute 'cost' for OpenAIWrapper when using AzuerOpenaAI
3 participants