Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifies the phrasing in notebook agent_hierarchy_flow_using_select_speaker #876

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

joshkyh
Copy link
Collaborator

@joshkyh joshkyh commented Dec 5, 2023

Why are these changes needed?

Improves on the phrasing "information flow" because agents do see the full context of what was previously discussed. It is therefore, not a limitation of information flow, but a limitation on the transition paths.

Related issue number

Clarifies #853
#853 (comment)

Checks

@joshkyh joshkyh requested review from sonichi, austinmw and gagb December 5, 2023 03:59
@joshkyh joshkyh self-assigned this Dec 5, 2023
@joshkyh joshkyh added the group chat/teams group-chat-related issues label Dec 5, 2023
@joshkyh joshkyh changed the title Clarifies #853 Clarifies the phrasing in notebook agenct_hierarchy_flow_using_select_speaker Dec 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a107233) 26.63% compared to head (da4c37c) 26.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   26.63%   26.63%           
=======================================
  Files          28       28           
  Lines        3725     3725           
  Branches      847      847           
=======================================
  Hits          992      992           
  Misses       2660     2660           
  Partials       73       73           
Flag Coverage Δ
unittests 26.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshkyh joshkyh added the documentation Improvements or additions to documentation label Dec 5, 2023
@joshkyh joshkyh changed the title Clarifies the phrasing in notebook agenct_hierarchy_flow_using_select_speaker Clarifies the phrasing in notebook agent_hierarchy_flow_using_select_speaker Dec 5, 2023
@sonichi sonichi added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit bb2bb8e Dec 5, 2023
16 checks passed
@sonichi sonichi deleted the amend_hierarchy_flow branch December 5, 2023 14:42
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation group chat/teams group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants