Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update position of registered custom generate_reply functions for contrib/ agents per PR #794 #871

Conversation

momuno
Copy link
Member

@momuno momuno commented Dec 5, 2023

Why are these changes needed?

PR #794 added registration of async human input handler. This bumped the position of the other default registered generate reply functions by 1. Two contrib/ agents were updated per this change (their generate_reply function was bumped by 1 to account for change), but three contrib/ agents were missed. This completes the bump by 1 for those three agents.

Related issue number

PR #794

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a107233) 26.63% compared to head (f8e97b8) 38.12%.

Files Patch % Lines
autogen/agentchat/contrib/teachable_agent.py 0.00% 1 Missing ⚠️
autogen/agentchat/contrib/text_analyzer_agent.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #871       +/-   ##
===========================================
+ Coverage   26.63%   38.12%   +11.48%     
===========================================
  Files          28       28               
  Lines        3725     3725               
  Branches      847      847               
===========================================
+ Hits          992     1420      +428     
+ Misses       2660     2182      -478     
- Partials       73      123       +50     
Flag Coverage Δ
unittests 38.06% <33.33%> (+11.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Dec 6, 2023
Merged via the queue into microsoft:main with commit fa11c4f Dec 6, 2023
80 of 84 checks passed
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants