Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected openai utils example #869

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

axa99
Copy link
Contributor

@axa99 axa99 commented Dec 5, 2023

Why are these changes needed?

The config_list_from_models example in notebook oai_openai_utils.ipynb had two entries for the keyword argument model_list and caused an error (screenshot attached).

autogen notebook error 12-04-2023

The code cell was updated to use a single model_list so the cell could be run successfully.

Checks

  • I've made sure all auto checks have passed.

@axa99
Copy link
Contributor Author

axa99 commented Dec 5, 2023

@microsoft-github-policy-service agree

Copy link
Contributor Author

@axa99 axa99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The config_list_from_models example in notebook oai_openai_utils.ipynb had two entries for the keyword argument model_list and was causing a syntax error.
  • The code cell was updated to use a single model_list so the cell could be run successfully.

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the catch!

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb2bb8e) 26.63% compared to head (008bbe7) 26.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   26.63%   26.63%           
=======================================
  Files          28       28           
  Lines        3725     3725           
  Branches      847      847           
=======================================
  Hits          992      992           
  Misses       2660     2660           
  Partials       73       73           
Flag Coverage Δ
unittests 26.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qingyun-wu qingyun-wu enabled auto-merge December 5, 2023 19:03
@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 5, 2023
Merged via the queue into microsoft:main with commit 195c87e Dec 5, 2023
16 checks passed
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
… tuning stop condition (microsoft#869)

* notebook test

* add ipykernel, remove except

* only create dir if not empty

* Stop sequential tuning when result is None

* fix reproducibility of global search

* save gs seed

* use get to avoid KeyError

* test
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants