-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected openai utils example #869
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
config_list_from_models
example in notebook oai_openai_utils.ipynb had two entries for the keyword argumentmodel_list
and was causing a syntax error. - The code cell was updated to use a single
model_list
so the cell could be run successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the catch!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
=======================================
Coverage 26.63% 26.63%
=======================================
Files 28 28
Lines 3725 3725
Branches 847 847
=======================================
Hits 992 992
Misses 2660 2660
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… tuning stop condition (microsoft#869) * notebook test * add ipykernel, remove except * only create dir if not empty * Stop sequential tuning when result is None * fix reproducibility of global search * save gs seed * use get to avoid KeyError * test
Why are these changes needed?
The
config_list_from_models
example in notebook oai_openai_utils.ipynb had two entries for the keyword argumentmodel_list
and caused an error (screenshot attached).The code cell was updated to use a single
model_list
so the cell could be run successfully.Checks