Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise error for content_filter #849

Merged
merged 4 commits into from
Dec 6, 2023
Merged

raise error for content_filter #849

merged 4 commits into from
Dec 6, 2023

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Dec 3, 2023

Why are these changes needed?

Raise content_filter error to match the behavior in v0.1, following #757.

Related issue number

Close #279

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fa11c4f) 26.63% compared to head (e49d65d) 51.07%.

Files Patch % Lines
autogen/oai/client.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #849       +/-   ##
===========================================
+ Coverage   26.63%   51.07%   +24.44%     
===========================================
  Files          28       28               
  Lines        3725     3728        +3     
  Branches      847      890       +43     
===========================================
+ Hits          992     1904      +912     
+ Misses       2660     1625     -1035     
- Partials       73      199      +126     
Flag Coverage Δ
unittests 50.91% <50.00%> (+24.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi requested review from afourney and olgavrou December 3, 2023 14:49
autogen/oai/client.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@monarchwadia monarchwadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for keeping me involved

@sonichi sonichi added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 31c1664 Dec 6, 2023
81 of 84 checks passed
@sonichi sonichi deleted the content_filter branch December 6, 2023 16:21
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
* raise error for content_filter

* use the code field

* simplify
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* FAQ about OOM

* reduce -> resolve
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* raise error for content_filter

* use the code field

* simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'str' object has no attribute 'get' after the task is finished
4 participants