Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testbed can now read the OPENAI_API_KEY in addition to OAI_CONFIG_LIST #848

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

afourney
Copy link
Member

@afourney afourney commented Dec 3, 2023

Why are these changes needed?

Previously, the Testbed would only provide the OAI_CONFIG_LIST to Docker containers when running scenarios. This commit also provides the OPENAI_API_KEY environment variable.

This additional key will become useful when loading configurations provided by the Autogen Assistant, which builds its own config_list, but depends on the OPENAI_API_KEY for the api_key.
 

Related issue number

N/A

Checks

@afourney afourney added ra-oss proj-autogenbench Issues related to AutoGenBench. labels Dec 3, 2023
@afourney afourney requested review from victordibia and a team December 3, 2023 05:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 304 lines in your changes are missing coverage. Please review.

Comparison is base (370ebf5) 29.81% compared to head (48c4df2) 25.34%.
Report is 51 commits behind head on main.

Files Patch % Lines
autogen/agentchat/contrib/agent_builder.py 0.00% 144 Missing ⚠️
autogen/oai/client.py 9.52% 76 Missing ⚠️
autogen/agentchat/conversable_agent.py 43.75% 17 Missing and 1 partial ⚠️
.../agentchat/contrib/multimodal_conversable_agent.py 0.00% 14 Missing ⚠️
autogen/agentchat/contrib/gpt_assistant_agent.py 0.00% 13 Missing ⚠️
...gen/agentchat/contrib/retrieve_user_proxy_agent.py 0.00% 13 Missing ⚠️
autogen/oai/openai_utils.py 25.00% 6 Missing ⚠️
autogen/retrieve_utils.py 0.00% 6 Missing ⚠️
autogen/agentchat/groupchat.py 77.77% 3 Missing and 1 partial ⚠️
autogen/agentchat/contrib/llava_agent.py 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   29.81%   25.34%   -4.48%     
==========================================
  Files          27       26       -1     
  Lines        3448     3717     +269     
  Branches      780      847      +67     
==========================================
- Hits         1028      942      -86     
- Misses       2346     2702     +356     
+ Partials       74       73       -1     
Flag Coverage Δ
unittests 25.34% <14.36%> (-4.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks

@sonichi sonichi added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit a107233 Dec 4, 2023
16 checks passed
@afourney afourney deleted the testbed_copy_oai_env branch December 14, 2023 18:26
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix bug related to _choice_

* remove py 3.6

* sanitize config

* optimize test
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proj-autogenbench Issues related to AutoGenBench.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants