Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docstring of query_texts and search_string #795

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

thinkall
Copy link
Collaborator

Why are these changes needed?

Address #728

Related issue number

Closes #728

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f96963e) 27.76% compared to head (fba21f4) 37.21%.

❗ Current head fba21f4 differs from pull request most recent head 40d65b8. Consider uploading reports for the commit 40d65b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
+ Coverage   27.76%   37.21%   +9.44%     
==========================================
  Files          27       27              
  Lines        3493     3493              
  Branches      791      791              
==========================================
+ Hits          970     1300     +330     
+ Misses       2452     2073     -379     
- Partials       71      120      +49     
Flag Coverage Δ
unittests 37.16% <ø> (+9.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rickyloynd-microsoft rickyloynd-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These clarifications make sense.

autogen/retrieve_utils.py Outdated Show resolved Hide resolved
@qingyun-wu qingyun-wu enabled auto-merge November 29, 2023 17:19
@qingyun-wu qingyun-wu added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 3c2a38e Nov 29, 2023
64 of 71 checks passed
@sonichi sonichi deleted the fix_728 branch November 29, 2023 20:48
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Improve docstring of query_texts and search_string

* Update docstring

* Update docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rag retrieve-augmented generative agents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could you please make this more descriptive?
5 participants