-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ChatCompletionMessage to Dict after completion #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
===========================================
+ Coverage 26.72% 37.96% +11.24%
===========================================
Files 28 28
Lines 3768 3777 +9
Branches 854 900 +46
===========================================
+ Hits 1007 1434 +427
+ Misses 2687 2217 -470
- Partials 74 126 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think this is also related to #765 |
sonichi
reviewed
Dec 10, 2023
sonichi
reviewed
Dec 10, 2023
sonichi
approved these changes
Dec 10, 2023
This was referenced Dec 13, 2023
rlam3
pushed a commit
to rlam3/autogen
that referenced
this pull request
Dec 19, 2023
* update * update * update signature * update * update * fix test funccall groupchat * reverse change * update * update * update * update * update --------- Co-authored-by: Qingyun Wu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* update * update * update signature * update * update * fix test funccall groupchat * reverse change * update * update * update * update * update --------- Co-authored-by: Qingyun Wu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
extract_text_or_function_call
->extract_text_or_completion_object
. The extraction is now a dict or an completion object, changing the name for clarity.Ensure the return from
generate_oai_reply
is a str or dict, which is a vulnerability.Note: Remaining issues with groupchat will be fixed in a separate PR. (When selector is making a function call).
Related issue number
#721
Checks