Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version condition to fix issue #775 #777

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove version condition to fix issue #775 #777

merged 1 commit into from
Nov 27, 2023

Conversation

thinkall
Copy link
Collaborator

@thinkall thinkall commented Nov 27, 2023

Why are these changes needed?

Remove version condition to fix issue #775

I did a quick search, the version conditions in notebooks have already been updated to ~0.2.0b5, so it has been verified that retrievechat works for 0.2.0 as well.

Related issue number

Closes #775

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0468f53) 27.81% compared to head (ed024cc) 27.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   27.81%   27.81%           
=======================================
  Files          27       27           
  Lines        3480     3480           
  Branches      789      789           
=======================================
  Hits          968      968           
  Misses       2441     2441           
  Partials       71       71           
Flag Coverage Δ
unittests 27.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 4edceab Nov 27, 2023
16 checks passed
@sonichi sonichi deleted the fix_#775 branch November 27, 2023 14:45
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* make performance test reproducible

* fix test error

* Doc update and disable logging

* document random_state and version

* remove hardcoded budget

* fix test error and dependency; close microsoft#777

* iloc
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@thinkall would you like to update line 98-100 about the version supported for retrievechat?
3 participants