Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar for learn_from_user_feedback #776

Merged
merged 8 commits into from
Nov 29, 2023
Merged

Progress bar for learn_from_user_feedback #776

merged 8 commits into from
Nov 29, 2023

Conversation

rickyloynd-microsoft
Copy link
Contributor

Why are these changes needed?

TeachableAgent.learn_from_user_feedback can take awhile to complete. This PR adds a progress bar.

Returning immediately for asynchronous behavior is one option, but that would cause problems for all of the current teachability tests, which immediately start a new chat assuming that the vector DB has been fully updated. If an application needs asynchronous behavior, it can easily call learn_from_user_feedback from a separate process. But our focus for now is research, and the teachability mechanisms are still evolving.

Related issue number

Closes #329

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.21%. Comparing base (f812a23) to head (6e577c8).
Report is 1718 commits behind head on main.

Files with missing lines Patch % Lines
autogen/agentchat/contrib/teachable_agent.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   27.76%   37.21%   +9.44%     
==========================================
  Files          27       27              
  Lines        3493     3493              
  Branches      791      791              
==========================================
+ Hits          970     1300     +330     
+ Misses       2452     2073     -379     
- Partials       71      120      +49
Flag Coverage Δ
unittests 37.16% <0.00%> (+9.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickyloynd-microsoft
Copy link
Contributor Author

@gagb @qingyun-wu Do one of you have time to review this small change?

@sonichi sonichi added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit f96963e Nov 29, 2023
64 of 71 checks passed
@rickyloynd-microsoft rickyloynd-microsoft deleted the progress branch November 29, 2023 00:43
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@rickyloynd-microsoft
Progress bar for learn_from_user_feedback (microsoft#776)
ac01f6e 
* Use tqdm to report progress in learn_from_user_feedback()

* Update contrib-openai.yml

Append `pytest-asyncio` to `pip install coverage` for TeachableAgent.

* Replace pytest-asyncio with pytest

* Temporary usage of pull_request action.

* Restore pull_request_target action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagb gagb gagb approved these changes

@qingyun-wu qingyun-wu Awaiting requested review from qingyun-wu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancements to TeachableAgent.learn_from_user_feedback
4 participants
@rickyloynd-microsoft @codecov-commenter @gagb @sonichi