Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to newly added notebooks in the website #756 #772

Conversation

olaoluwasalami
Copy link
Collaborator

@sonichi @thinkall @BeibinLi

add a new notebook to website

Related issue number

#756

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8d0527) 27.81% compared to head (dfa857d) 27.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   27.81%   27.81%           
=======================================
  Files          27       27           
  Lines        3480     3480           
  Branches      789      789           
=======================================
  Hits          968      968           
  Misses       2441     2441           
  Partials       71       71           
Flag Coverage Δ
unittests 27.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BeibinLi @qingyun-wu where are the other multimodal notebook examples?
We have two webpages that contain the same set of examples. People often forget to update them both. What shall we do?

@olaoluwasalami
Copy link
Collaborator Author

@BeibinLi @qingyun-wu where are the other multimodal notebook examples? We have two webpages that contain the same set of examples. People often forget to update them both. What shall we do?

I can handle this webpages going forward @sonichi

website/docs/Examples/AgentChat.md Outdated Show resolved Hide resolved
website/docs/Use-Cases/agent_chat.md Outdated Show resolved Hide resolved
@qingyun-wu
Copy link
Contributor

@BeibinLi @qingyun-wu where are the other multimodal notebook examples? We have two webpages that contain the same set of examples. People often forget to update them both. What shall we do?

I can handle this webpages going forward @sonichi

@olaoluwasalami thanks for being willing to help on this. Going forward we may want to consider re-factoring the website so that the links to notebooks do not appear on two pages. @sonichi

@olaoluwasalami
Copy link
Collaborator Author

PR updated @qingyun-wu

@qingyun-wu qingyun-wu added this pull request to the merge queue Nov 27, 2023
@qingyun-wu qingyun-wu removed this pull request from the merge queue due to a manual request Nov 27, 2023
Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@qingyun-wu qingyun-wu added this pull request to the merge queue Nov 27, 2023
Merged via the queue into microsoft:main with commit 37ec154 Nov 27, 2023
16 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…osoft#772)

* wip

* remove spaces

* :

* pr updated

* change to wip

* Created a new subsection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants