Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message "content" now supports both str and List in Agents #713

Merged
merged 27 commits into from
Dec 3, 2023
Merged

Message "content" now supports both str and List in Agents #713

merged 27 commits into from
Dec 3, 2023

Conversation

BeibinLi
Copy link
Collaborator

@BeibinLi BeibinLi commented Nov 18, 2023

Why are these changes needed?

Related issue number

#658
#628
#513

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4503679) 27.66% compared to head (481e322) 39.45%.

Files Patch % Lines
.../agentchat/contrib/multimodal_conversable_agent.py 64.28% 4 Missing and 1 partial ⚠️
autogen/agentchat/groupchat.py 84.61% 1 Missing and 1 partial ⚠️
autogen/code_utils.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #713       +/-   ##
===========================================
+ Coverage   27.66%   39.45%   +11.78%     
===========================================
  Files          27       27               
  Lines        3517     3523        +6     
  Branches      801      803        +2     
===========================================
+ Hits          973     1390      +417     
+ Misses       2473     2011      -462     
- Partials       71      122       +51     
Flag Coverage Δ
unittests 39.39% <83.01%> (+11.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeibinLi
Copy link
Collaborator Author

An important style question: there is an important content_str function will cast content from supporting types to string (for printing, extracting code, and other purposes). It is in code_utils.py now, but should we move it to some other places because it is not only used for coding.

https://github.com/BeibinLi/autogen/blob/24807be4c8d823d72b8e8c19660e92ef6882c3e4/autogen/code_utils.py#L33

@sonichi sonichi added this pull request to the merge queue Dec 3, 2023
Merged via the queue into microsoft:main with commit c19f234 Dec 3, 2023
76 of 83 checks passed
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
…soft#713)

* Change "content" type in Conversable Agent

* content and system_message support str and List
Update for all other agents

* Content_str now also takes None as input

* Group Chat now works with LMM too

* Style: newline for import in Conversable Agentt

* Add test for gourpchat + lmm

* Resolve comments
1. Undo AssistantAgent changes
2. Modify the asserts and raises in `content_str` function and update
test accordingly.

* Undo AssistantAgent

* Update comments and add assertion for LMM

* Typo fix in docstring for content_str

* Remove “None” out conversable_agent.py

* Lint message to dict in multimodal_conversable_agent.py

* Address lint issues

* linting

* Move lmm test into contrib test

* Resolve 2 comments

* Move img_utils into contrib folder

* Resolve img_utils path issues
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…soft#713)

* Change "content" type in Conversable Agent

* content and system_message support str and List
Update for all other agents

* Content_str now also takes None as input

* Group Chat now works with LMM too

* Style: newline for import in Conversable Agentt

* Add test for gourpchat + lmm

* Resolve comments
1. Undo AssistantAgent changes
2. Modify the asserts and raises in `content_str` function and update
test accordingly.

* Undo AssistantAgent

* Update comments and add assertion for LMM

* Typo fix in docstring for content_str

* Remove “None” out conversable_agent.py

* Lint message to dict in multimodal_conversable_agent.py

* Address lint issues

* linting

* Move lmm test into contrib test

* Resolve 2 comments

* Move img_utils into contrib folder

* Resolve img_utils path issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants