Fixes cache issue from 703 and 679 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sonichi While I was in there, fixing cache, I noticed that the filter logic only ever applied to cached responses. Is this what was intended? Or is that a separate bug? |
sonichi
reviewed
Nov 19, 2023
Co-authored-by: Chi Wang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
===========================================
+ Coverage 29.81% 49.08% +19.27%
===========================================
Files 27 27
Lines 3448 3455 +7
Branches 780 824 +44
===========================================
+ Hits 1028 1696 +668
+ Misses 2346 1582 -764
- Partials 74 177 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Avoid creating cache database when cache_seed is None (which disables cache) * Add some debugging. * Removed some debugging. * Update autogen/oai/client.py Co-authored-by: Chi Wang <[email protected]> * Fixed missing filter function logic from oai/client.py --------- Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The cache database is created even when caching is disabled. This raises issues on read-only filesystems, and is also generally unpleasant, as it leaves debris everywhere it is run. This PR fixed the issue.
Related issue number
Closes #703 and #679
Checks