-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update speaker selector in GroupChat and update some notebooks #688
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 29.05% 38.02% +8.96%
==========================================
Files 27 27
Lines 3407 3448 +41
Branches 767 780 +13
==========================================
+ Hits 990 1311 +321
+ Misses 2345 2018 -327
- Partials 72 119 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @afourney , I think it's OK to just remove |
No, we cannot remove _participant_roles, as this is a major change, and a key way that the GroupChat knows what each agent is capable of (otherwise it's only guessing from the agent names). The right solution here is to add an optional agents parameter to _participant_roles, (default it to self.agents). That way we can pass it the reduced list of agents. This also needs to be fixed in a similar way:
|
Oh, yes, I missed the |
…epeat_speaker = False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I have fixed the bugs that were found earlier I am hardly an unbiased reviewer now, however.
…soft#688) * Add speaker selection methods * Update groupchat RAG * Update seed to cache_seed * Update RetrieveChat notebook * Update parameter name * Add test * Add more tests * Add mock to test * Add mock to test * Fix typo speaking * Add gracefully exit manual input * Update round_robin docstring * Add method checking * Remove participant roles * Fix versions in notebooks * Minimize installation overhead * Fix missing lower() * Add comments for try_count 3 * Update warning for n_agents < 3 * Update warning for n_agents < 3 * Add test_n_agents_less_than_3 * Add a function for manual select * Update version in notebooks * Fixed bugs that allow speakers to go twice in a row even when allow_repeat_speaker = False --------- Co-authored-by: Adam Fourney <[email protected]>
Why are these changes needed?
There are a lot of ask for having more control on speaker selection. In this PR, several speaker selection methods are enabled. A parameter
allow_repeat_speaker
is also added to determine whether to allow the same speaker to speak consecutively.groupchat_RAG notebook is updated accordingly.
Besides:
seed
is renamed tocache_seed
.Related issue number
Closes #151
Checks