-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FAQ.md with api_base vs base_url question #672
Conversation
added a faq for api_base vs base_url because people were asking about it frequently.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 28.70% 28.70%
=======================================
Files 27 27
Lines 3383 3383
Branches 760 760
=======================================
Hits 971 971
Misses 2341 2341
Partials 71 71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Do we need it given: |
I think the repetition is helpful for people who don't carefully read or remember the migration guide, and people who pick up an old piece of code from somewhere without realizing there was an API migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Alternatively, should we check "api_base" and "base_url" in the config dictionary, and decide which one to use based on the OpenAI Version? |
How about adding a link to the migration guide page too? |
That's also a good idea. |
added a faq for api_base vs base_url because people were asking about it frequently.
Why are these changes needed?
added a faq for api_base vs base_url because people were asking about it frequently.
Related issue number
Checks