-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add missing C# and F# kernels #6283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add missing C# and F# kernels.
|
@amoghmc I thought the C# and F# kernel already there by default? |
They were but a recent commit removed them so I am adding them back again. |
|
@amoghmc Sorry for the confusion, what I meant was wouldn't the C# and F# kernel already added to What error did you see when you create |
|
|
Although the actual fix was this: This is because .AddCSharpKernel() results in this error below:
As the default value would end up as ["c#", "C#", "csharp"] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6283 +/- ##
==========================================
- Coverage 77.24% 73.02% -4.23%
==========================================
Files 200 306 +106
Lines 14473 17591 +3118
Branches 0 406 +406
==========================================
+ Hits 11180 12845 +1665
- Misses 3293 4473 +1180
- Partials 0 273 +273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@amoghmc Thanks for the PR, merging now |
Add missing C# and F# kernels.
These are needed to create a default kernel else it will return an empty kernel.