Support a wider range of termination conditions in AGS #6273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#6163 Added support for a broader range of termination conditions in AGS UI to ensure parity with AgentChat * **Abstractions/Termination.cs**: Add new termination conditions `FunctionCallTermination`, `HandoffTermination`, `TokenUsageTermination`, `SourceMatchTermination`, `TextMentionTermination`, and `StopMessageTermination` to the `ITerminationCondition` interface. Update the `CombinerCondition` class to support the new termination conditions. * **Terminations/ExternalTermination.cs**: Update the `ExternalTermination` class to support the new termination conditions. * **Terminations/FunctionCallTermination.cs**: Update the `FunctionCallTermination` class to support the new termination conditions. * **Terminations/HandoffTermination.cs**: Update the `HandoffTermination` class to support the new termination conditions. * **Terminations/TokenUsageTermination.cs**: Update the `TokenUsageTermination` class to support the new termination conditions. * **Terminations/SourceMatchTermination.cs**: Update the `SourceMatchTermination` class to support the new termination conditions. * **Terminations/TextMentionTermination.cs**: Update the `TextMentionTermination` class to support the new termination conditions. * **Terminations/StopMessageTermination.cs**: Update the `StopMessageTermination` class to support the new termination conditions. * **Tests/TerminationConditionTests.cs**: Add unit tests for the new termination conditions in the `TerminationConditionTests` class.
Collaborator
|
Thanks for the PR. if you meant to create termination conditions for the dotnet agentchat implementation, it would be great if you can create an issue/discussion and then proceed from there. Closing this one out for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6163
Added support for a broader range of termination conditions in AGS UI to ensure parity with AgentChat
FunctionCallTermination,HandoffTermination,TokenUsageTermination,SourceMatchTermination,TextMentionTermination, andStopMessageTerminationto theITerminationConditioninterface. Update theCombinerConditionclass to support the new termination conditions.ExternalTerminationclass to support the new termination conditions.FunctionCallTerminationclass to support the new termination conditions.HandoffTerminationclass to support the new termination conditions.TokenUsageTerminationclass to support the new termination conditions.SourceMatchTerminationclass to support the new termination conditions.TextMentionTerminationclass to support the new termination conditions.StopMessageTerminationclass to support the new termination conditions.TerminationConditionTestsclass.