-
Notifications
You must be signed in to change notification settings - Fork 8k
Implements suggestion discussed in issue #6049 by adding raw_response field to CreateResult. #6192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ekzhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The uv.lock file shouldn't be changed.
python/uv.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to delete this file. I meant we should keep this file unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to delete this file. I meant we should keep this file unchanged.
I’ve reverted uv.lock to match main exactly.
Could you please confirm that everything looks correct? Thanks!
|
Can you resolve the conflict with the main branch? So we can make sure there is no changes to |
Hi @ekzhu, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of test cases and auto checks are failing. Please follow python/README.md
Why are these changes needed?
This PR adds a new
raw_responsefield to theCreateResultclass to store the original response object returned by the model.Related issue number
Closes #6049
Checks