Skip to content

Conversation

@tongyu0924
Copy link
Contributor

Why are these changes needed?

This PR adds a new raw_response field to the CreateResult class to store the original response object returned by the model.

Related issue number

Closes #6049

Checks

Copy link
Contributor

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uv.lock file shouldn't be changed.

python/uv.lock Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to delete this file. I meant we should keep this file unchanged.

Copy link
Contributor Author

@tongyu0924 tongyu0924 Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to delete this file. I meant we should keep this file unchanged.

I’ve reverted uv.lock to match main exactly.
Could you please confirm that everything looks correct? Thanks!

@ekzhu
Copy link
Contributor

ekzhu commented Apr 9, 2025

Can you resolve the conflict with the main branch? So we can make sure there is no changes to uv.lock in this PR.

@tongyu0924
Copy link
Contributor Author

Can you resolve the conflict with the main branch? So we can make sure there is no changes to uv.lock in this PR.

Hi @ekzhu,
I have resolved the conflict with the main branch and confirmed no changes to the uv.lock file in this PR. Feel free to review the updated changes.

Thanks!

Copy link
Contributor

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of test cases and auto checks are failing. Please follow python/README.md

@tongyu0924 tongyu0924 requested a review from ekzhu April 26, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CreateResult.request_id field for tracking model usage.

2 participants