Skip to content

No-op message_handler (and sibling) decorators for abstract methods #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nissa-seru wants to merge 5 commits into
base: main
Choose a base branch
from
Open

No-op message_handler (and sibling) decorators for abstract methods #5945

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b32de4
no-op message_handler (and sibling) decorators for abstract methods
nissa-seru Mar 14, 2025
85bfaa1
Merge branch 'main' into message-handler-abstract
nissa-seru Mar 14, 2025
e6a9590
Merge branch 'main' into message-handler-abstract
nissa-seru Mar 15, 2025
2769ee1
Merge branch 'main' into message-handler-abstract
nissa-seru Mar 15, 2025
d403cd4
Merge branch 'main' into message-handler-abstract
nissa-seru Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/packages/autogen-core/src/autogen_core/_routed_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ async def wrapper(self: AgentT, message: ReceivesT, ctx: MessageContext) -> Prod

return wrapper_handler

if func is None and not callable(func):
if func is None and not callable(func) or getattr(func, "__isabstractmethod__", False):
return decorator
elif callable(func):
return decorator(func)
Expand Down Expand Up @@ -284,7 +284,7 @@ async def wrapper(self: AgentT, message: ReceivesT, ctx: MessageContext) -> None

return wrapper_handler

if func is None and not callable(func):
if func is None and not callable(func) or getattr(func, "__isabstractmethod__", False):
return decorator
elif callable(func):
return decorator(func)
Expand Down Expand Up @@ -404,7 +404,7 @@ async def wrapper(self: AgentT, message: ReceivesT, ctx: MessageContext) -> Prod

return wrapper_handler

if func is None and not callable(func):
if func is None and not callable(func) or getattr(func, "__isabstractmethod__", False):
return decorator
elif callable(func):
return decorator(func)
Expand Down