-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to register a rely function Issue-478 #579
how to register a rely function Issue-478 #579
Conversation
@microsoft-github-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=======================================
Coverage 27.81% 27.81%
=======================================
Files 27 27
Lines 3480 3480
Branches 789 789
=======================================
Hits 968 968
Misses 2441 2441
Partials 71 71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, @olaoluwasalami !
It's worth mentioning more use cases for this, for example, adding a send_message_to_ui
function that sends the received message to the UI or a remote endpoint.
@sonichi , this could be a handy way to address some issues raised in the community. We should emphasize this function. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @thinkall about the importance. It's worth a more detailed documentation or a blog post. It's OK to have this section here in FAQ before that.
@sonichi Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Head branch was pushed to by a user without write access
@sonichi auto-merge disabled |
* how to register a rely function Issue-478 * updated PR * added example * wip * fixed erors
@sonichi @victordibia @thinkall
Why are these changes needed?
FAQ: How to register a reply function
Related issue number
Closes #559
Checks