Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to register a rely function Issue-478 #579

Conversation

olaoluwasalami
Copy link
Collaborator

@olaoluwasalami olaoluwasalami commented Nov 7, 2023

@sonichi @victordibia @thinkall

Why are these changes needed?

FAQ: How to register a reply function

Related issue number

Closes #559

Checks

@olaoluwasalami
Copy link
Collaborator Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8d0527) 27.81% compared to head (4edbf54) 27.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   27.81%   27.81%           
=======================================
  Files          27       27           
  Lines        3480     3480           
  Branches      789      789           
=======================================
  Hits          968      968           
  Misses       2441     2441           
  Partials       71       71           
Flag Coverage Δ
unittests 27.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @olaoluwasalami !

It's worth mentioning more use cases for this, for example, adding a send_message_to_ui function that sends the received message to the UI or a remote endpoint.

@sonichi , this could be a handy way to address some issues raised in the community. We should emphasize this function. WDYT?

website/docs/FAQ.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @thinkall about the importance. It's worth a more detailed documentation or a blog post. It's OK to have this section here in FAQ before that.

website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
@olaoluwasalami
Copy link
Collaborator Author

@sonichi Please review.

website/docs/FAQ.md Outdated Show resolved Hide resolved
Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
@sonichi sonichi added the documentation Improvements or additions to documentation label Nov 27, 2023
auto-merge was automatically disabled November 27, 2023 00:52

Head branch was pushed to by a user without write access

@olaoluwasalami
Copy link
Collaborator Author

@sonichi auto-merge disabled

@qingyun-wu qingyun-wu added this pull request to the merge queue Nov 27, 2023
Merged via the queue into microsoft:main with commit 34b90e4 Nov 27, 2023
16 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* how to register a rely function Issue-478

* updated PR

* added example

* wip

* fixed erors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples of how to register a reply function
7 participants