Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in function helper text #503

Merged
merged 6 commits into from
Nov 19, 2023
Merged

fix typos in function helper text #503

merged 6 commits into from
Nov 19, 2023

Conversation

shresthasurav
Copy link
Contributor

Why are these changes needed?

This pull request fixes typos in python function helper text which enhances readability. I kindly request the repository maintainers to review and merge it. Thanks! ❤️

Related issue number

Checks

sonichi
sonichi reviewed Nov 5, 2023
View reviewed changes
Copy link
Contributor

@sonichi sonichi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. One change is suggested. Please fix the conflict with main.

test/agentchat/test_assistant_agent.py Outdated Show resolved Hide resolved
@sonichi sonichi requested a review from a team November 5, 2023 18:15
@sonichi sonichi added the documentation Improvements or additions to documentation label Nov 5, 2023
@shresthasurav
Copy link
Contributor Author

Thanks. One change is suggested. Please fix the conflict with main.

I have made the necessary change. I kindly request you to review it. Thanks! ❤️

pcdeadeasy
pcdeadeasy approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@pcdeadeasy pcdeadeasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonichi
Copy link
Contributor

sonichi commented Nov 7, 2023

Thanks. One change is suggested. Please fix the conflict with main.

I have made the necessary change. I kindly request you to review it. Thanks! ❤️

Please resolve the conflict with main.

@sonichi sonichi requested a review from a team November 7, 2023 22:16
@sonichi
Copy link
Contributor

sonichi commented Nov 19, 2023

@shresthasurav could you please resolve the conflict if you'd still like this PR to be merged?

@shresthasurav
Copy link
Contributor Author

@shresthasurav could you please resolve the conflict if you'd still like this PR to be merged?

@sonichi I have resolved the conflict with main. I kindly request you to review and merge the pull request.

Thanks! ❤️

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75cc763) 29.81% compared to head (cb53b28) 38.02%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   29.81%   38.02%   +8.20%     
==========================================
  Files          27       27              
  Lines        3448     3448              
  Branches      780      780              
==========================================
+ Hits         1028     1311     +283     
+ Misses       2346     2018     -328     
- Partials       74      119      +45
Flag Coverage Δ
unittests 37.96% <ø> (+8.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Nov 19, 2023
Merged via the queue into microsoft:main with commit a4d9ce8 Nov 19, 2023
52 of 58 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@shresthasurav @sonichi
fix typos in function helper text (microsoft#503)
c4d1018 
* fix typos in autogen/agentchat/conversable_agent.py

* fix typos in autogen/code_utils.py

* fix typos in autogen/oai/completion.py

* fix typos in test/agentchat/test_assistant_agent.py

* Update test/agentchat/test_assistant_agent.py

Co-authored-by: Chi Wang <[email protected]>

---------

Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonichi sonichi sonichi left review comments

@pcdeadeasy pcdeadeasy pcdeadeasy approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shresthasurav @sonichi @codecov-commenter @pcdeadeasy