Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to migration-guide.md #4888

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Minor updates to migration-guide.md #4888

merged 2 commits into from
Jan 4, 2025

Conversation

victordibia
Copy link
Collaborator

@victordibia victordibia commented Jan 3, 2025

Migration guide looks great and detailed!

This PR proposes a simple change ..

  • remove unecessary todo links

Why are these changes needed?

Related issue number

Checks

- remove unecessary todo links
@victordibia victordibia requested a review from ekzhu January 3, 2025 19:34
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (e168616) to head (b89bb06).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4888   +/-   ##
=======================================
  Coverage   68.21%   68.21%           
=======================================
  Files         158      158           
  Lines        9960     9960           
=======================================
  Hits         6794     6794           
  Misses       3166     3166           
Flag Coverage Δ
unittests 68.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victordibia
Copy link
Collaborator Author

@jackgerrits .. any change this is a known issue?
image

@jackgerrits
Copy link
Member

Yeah known issue - ignore for now

@jackgerrits jackgerrits closed this Jan 4, 2025
@jackgerrits jackgerrits reopened this Jan 4, 2025
@jackgerrits
Copy link
Member

Sorry - misclick on the close

@victordibia victordibia merged commit 2eb46d2 into main Jan 4, 2025
109 of 111 checks passed
@victordibia victordibia deleted the victordibia-patch-1 branch January 4, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants